Skip to content

Commit 24836d7

Browse files
lec-bitlec-bit
authored andcommitted
fix DATA RACE in TestCertRoute
Signed-off-by: lec-bit <glfhmzmy@126.com>
1 parent d8c0539 commit 24836d7

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/controller/security/manager_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,14 @@ func runTestCertRotate(t *testing.T) {
122122
// wait for rotate cert
123123
time.Sleep(2 * time.Second)
124124
for {
125-
cert2 := secretManager.GetCert(identity1)
125+
secretManager.certsCache.mu.RLock()
126+
cert2 := secretManager.certsCache.certs[identity1]
126127
if cert2 != nil && cert2.cert.CreatedTime != oldCert.CreatedTime {
127-
secretManager.certsCache.mu.RLock()
128128
newCert = *cert2.cert
129129
secretManager.certsCache.mu.RUnlock()
130130
break
131131
}
132+
secretManager.certsCache.mu.RUnlock()
132133
time.Sleep(100 * time.Millisecond)
133134
}
134135

0 commit comments

Comments
 (0)