Use cross-platform way to set -Werror (#351)

Author: aobolensk

cmake/configure.cmake

@@ -24,6 +24,8 @@ else ()
     set( CMAKE_CXX_STANDARD 20 )
 endif ()
 
+set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
+
 if( UNIX )
     set(COMMON_COMPILER_FLAGS
         "${COMMON_COMPILER_FLAGS}            \
@@ -54,8 +56,6 @@ if( UNIX )
         set (COMMON_COMPILER_FLAGS "${COMMON_COMPILER_FLAGS} -Wno-cast-align")
     endif()
 
-    set (COMMON_COMPILER_FLAGS "${COMMON_COMPILER_FLAGS} -Werror")
-
     set(CMAKE_C_FLAGS  "${CMAKE_C_FLAGS} ${COMMON_COMPILER_FLAGS}")
     set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} ${COMMON_COMPILER_FLAGS}")
     if (USE_COVERAGE)
@@ -73,7 +73,7 @@ if( MSVC )
         set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} ${COMMON_COMPILER_FLAGS}")
     endif()
     set(CMAKE_EXE_LINKER_FLAGS  "${CMAKE_EXE_LINKER_FLAGS}")
-    set(COMMON_FLAGS "/W4 /wd4267 /wd4244 /wd4100 /WX")
+    set(COMMON_FLAGS "/W4 /wd4267 /wd4244 /wd4100")
     set(CMAKE_C_FLAGS_RELEASE   "${CMAKE_C_FLAGS_RELEASE} ${COMMON_FLAGS}" )
     set(CMAKE_C_FLAGS_DEBUG     "${CMAKE_C_FLAGS_DEBUG} ${COMMON_FLAGS}")
     set(CMAKE_C_FLAGS           "${CMAKE_C_FLAGS} ${COMMON_FLAGS}" )