Enable 'cppcoreguidelines-*' checks in clang-tidy (#347)

Author: aobolensk

.clang-tidy

@@ -1,8 +1,7 @@
 Checks: >
   bugprone-*,
   clang-diagnostic-*,
-  cppcoreguidelines-init-variables,
-  cppcoreguidelines-pro-type-cstyle-cast,
+  cppcoreguidelines-*,
   llvm-include-order,
   llvm-namespace-comment,
   misc-*,
@@ -14,6 +13,14 @@ Checks: >
   -bugprone-casting-through-void,
   -bugprone-exception-escape,
   -bugprone-implicit-widening-of-multiplication-result,
+  -cppcoreguidelines-avoid-goto,
+  -cppcoreguidelines-avoid-magic-numbers,
+  -cppcoreguidelines-non-private-member-variables-in-classes,
+  -cppcoreguidelines-owning-memory,
+  -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+  -cppcoreguidelines-pro-type-reinterpret-cast,
+  -cppcoreguidelines-pro-type-vararg,
+  -cppcoreguidelines-special-member-functions,
   -misc-const-correctness,
   -misc-header-include-cycle,
   -misc-no-recursion,

modules/core/task/include/task.hpp

@@ -63,7 +63,7 @@ class Task {
  private:
   std::vector<std::string> functions_order_;
   std::vector<std::string> right_functions_order_ = {"Validation", "PreProcessing", "Run", "PostProcessing"};
-  const double max_test_time_ = 1.0;
+  static constexpr double kMaxTestTime = 1.0;
   std::chrono::high_resolution_clock::time_point tmp_time_point_;
 };
 

modules/core/task/src/task.cpp

@@ -63,11 +63,11 @@ void ppc::core::Task::InternalOrderTest(const std::string& str) {
     auto duration = std::chrono::duration_cast<std::chrono::nanoseconds>(end - tmp_time_point_).count();
     auto current_time = static_cast<double>(duration) * 1e-9;
     std::stringstream err_msg;
-    if (current_time < max_test_time_) {
+    if (current_time < kMaxTestTime) {
       err_msg << "Test time:" << std::fixed << std::setprecision(10) << current_time;
     } else {
       err_msg << "\nTask execute time need to be: ";
-      err_msg << "time < " << max_test_time_ << " secs.\n";
+      err_msg << "time < " << kMaxTestTime << " secs.\n";
       err_msg << "Original time in secs: " << current_time << '\n';
       throw std::runtime_error(err_msg.str().c_str());
     }