add test cases for simple exchange and error responses. Don't always pass functions object, don't return status on malformed 200 status output

Author: leafo

openai/init.lua

@@ -165,7 +165,8 @@ do
       end
       local out, err = parse_chat_response(response)
       if not (out) then
-        return nil, err, status, response
+        err = "Failed to parse response from server: " .. tostring(err)
+        return nil, err, response
       end
       if append_response then
         self:append_message(out.message)
@@ -181,11 +182,11 @@ do
       end
       self.client, self.opts = client, opts
       self.messages = { }
-      self.functions = { }
       if type(self.opts.messages) == "table" then
         self:append_message(unpack(self.opts.messages))
       end
       if type(self.opts.functions) == "table" then
+        self.functions = { }
         local _list_0 = self.opts.functions
         for _index_0 = 1, #_list_0 do
           local func = _list_0[_index_0]

openai/init.moon

@@ -123,12 +123,12 @@ parse_error_message = types.partial {
 class ChatSession
   new: (@client, @opts={}) =>
     @messages = {}
-    @functions = {}
 
     if type(@opts.messages) == "table"
       @append_message unpack @opts.messages
 
     if type(@opts.functions) == "table"
+      @functions = {}
       for func in *@opts.functions
         assert test_function func
         table.insert @functions, func
@@ -201,7 +201,8 @@ class ChatSession
     out, err = parse_chat_response response
 
     unless out
-      return nil, err, status, response
+      err = "Failed to parse response from server: #{err}"
+      return nil, err, response
 
     if append_response
       @append_message out.message

spec/openai_spec.moon

@@ -63,7 +63,7 @@ describe "OpenAI API Client", ->
     assert.same 200, status
     assert.same "This is a completion response.", response.choices[1].text
 
-  describe "chat session #ddd", ->
+  describe "chat session", ->
     local snapshot
     before_each = ->
       snapshot = assert\snapshot!
@@ -72,8 +72,128 @@ describe "OpenAI API Client", ->
       snapshot\revert!
 
     it "simple exchange", ->
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        assert.same {
+          {
+            role: "user"
+            content: "Who are you?"
+          }
+        }, messages
+        assert.same {
+          temperature: 0.75
+        }, params
+
+        200, {
+          usage: {}
+          choices: {
+            {
+              message: {
+                content: "I am you"
+                role: "assistant"
+              }
+            }
+          }
+        }
+
+      client = OpenAI "test-api-key"
+      chat = client\new_chat_session { temperature: .75 }
+      res = assert chat\send "Who are you?"
+      assert.same "I am you", res
+
+      -- verify that all the messages are stored
+      assert.same {
+        {
+          role: "user"
+          content: "Who are you?"
+        }
+        {
+          role: "assistant"
+          content: "I am you"
+        }
+      }, chat.messages
 
-    it "handles error", ->
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        assert.same {
+          {
+            role: "user"
+            content: "Who are you?"
+          }
+          {
+            role: "assistant"
+            content: "I am you"
+          }
+          {
+            role: "user"
+            content: "Thank you"
+          }
+        }, messages
+        assert.same {
+          temperature: 0.75
+        }, params
+
+        200, {
+          usage: {}
+          choices: {
+            {
+              message: {
+                content: "You're welcome"
+                role: "assistant"
+              }
+            }
+          }
+        }
+
+      assert.same "You're welcome", chat\send "Thank you"
+
+    it "handles error responses", ->
+      client = OpenAI "test-api-key"
+      chat = client\new_chat_session { model: "gpt-4" }
+
+      -- bad status
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        400, {}
+
+      assert.same {nil, "Bad status: 400", {}}, {chat\send "Hello"}
+
+      -- bad status with error
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        400, {
+          error: {
+            message: "Not valid thing"
+          }
+        }
+
+      assert.same {nil, "Bad status: 400: Not valid thing", {
+        error: {
+          message: "Not valid thing"
+        }
+      }}, {chat\send "Hello"}
+
+      -- bad status with error message and code
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        400, {
+          error: {
+            message: "Not valid thing"
+            code: "99"
+          }
+        }
+
+      assert.same {nil, "Bad status: 400: Not valid thing (99)", {
+        error: {
+          message: "Not valid thing"
+          code: "99"
+        }
+      }}, {chat\send "Hello"}
+
+      -- malformed output
+      stub(OpenAI.__base, "chat").invokes (c, messages, params) ->
+        200, { usage: {} }
+
+      assert.same {
+        nil
+        [[Failed to parse response from server: field "choices": expected type "table", got "nil"]]
+        { usage: {}}
+      }, {chat\send "Hello"}
 
     it "with functions", ->
       stub(OpenAI.__base, "chat").invokes (c, args, params) ->