Changing the way we handle comments

Author: keelerm84

contract-tests/src/bin/sse-test-api/main.rs

@@ -81,6 +81,7 @@ struct Event {
 async fn status() -> impl Responder {
     web::Json(Status {
         capabilities: vec![
+            "comments".to_string(),
             "headers".to_string(),
             "last-event-id".to_string(),
             "read-timeout".to_string(),

eventsource-client/src/event_parser.rs

@@ -235,6 +235,8 @@ impl EventParser {
 
                     if key == "comment" {
                         event_data.comment = Some(value.to_string());
+                        seen_empty_line = true;
+                        break;
                     } else if key == "event" {
                         event_data.event_type = value.to_string()
                     } else if key == "data" {
@@ -549,14 +551,14 @@ mod tests {
         require_pop_event(&mut parser, |e| assert_eq!(e.id, Some("3".into())));
     }
 
-    #[test_case(b":hello\n"; "with LF")]
-    #[test_case(b":hello\r"; "with CR")]
-    #[test_case(b":hello\r\n"; "with CRLF")]
-    fn test_decode_chunks_comments_are_ignored(chunk: &'static [u8]) {
-        let mut parser = EventParser::new();
-        assert!(parser.process_bytes(Bytes::from(chunk)).is_ok());
-        assert!(parser.get_event().is_none());
-    }
+    // #[test_case(b":hello\n"; "with LF")]
+    // #[test_case(b":hello\r"; "with CR")]
+    // #[test_case(b":hello\r\n"; "with CRLF")]
+    // fn test_decode_chunks_comments_are_ignored(chunk: &'static [u8]) {
+    //     let mut parser = EventParser::new();
+    //     assert!(parser.process_bytes(Bytes::from(chunk)).is_ok());
+    //     assert!(parser.get_event().is_none());
+    // }
 
     #[test_case(&["data:", "hello\n\n"], event("message", "hello"); "data split")]
     #[test_case(&["data:hell", "o\n\n"], event("message", "hello"); "data truncated")]