Skip to content

Commit 7fcb9b2

Browse files
authored
Update usage of shared tests repository (#12)
Now that this package is supporting 2 different major versions of the PHP SDK, it is important we ensure the tests can run against both branches. This necessitates some changes to the structure of our CI tests.
1 parent a383c4e commit 7fcb9b2

File tree

12 files changed

+16
-566
lines changed

12 files changed

+16
-566
lines changed

.circleci/config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,23 @@ workflows:
66
- linux-test:
77
name: PHP 7.3
88
docker-image: cimg/php:7.3
9+
shared-tests: 4.x-dev
910
- linux-test:
1011
name: PHP 7.4
1112
docker-image: cimg/php:7.4
13+
shared-tests: 4.x-dev
1214
- linux-test:
1315
name: PHP 8.0
1416
docker-image: cimg/php:8.0
17+
shared-tests: dev-main
1518

1619
jobs:
1720
linux-test:
1821
parameters:
1922
docker-image:
2023
type: string
24+
shared-tests:
25+
type: string
2126

2227
docker:
2328
- image: <<parameters.docker-image>>
@@ -33,6 +38,9 @@ jobs:
3338
- run:
3439
name: install dependencies
3540
command: composer install --no-progress
41+
- run:
42+
name: require appropriate shared tests package
43+
command: composer require --dev 'launchdarkly/server-sdk-shared-tests:<<parameters.shared-tests>>'
3644
- run: mkdir -p ./phpunit
3745
- run:
3846
name: run tests

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"repositories": [
33
{
4-
"type": "path",
5-
"url": "php-server-sdk-shared-tests"
4+
"type": "vcs",
5+
"url": "https://github.com/launchdarkly/php-server-sdk-shared-tests"
66
}
77
],
88
"name": "launchdarkly/server-sdk-redis-phpredis",
@@ -24,7 +24,6 @@
2424
"launchdarkly/server-sdk": ">=4.0.0 <6.0.0"
2525
},
2626
"require-dev": {
27-
"launchdarkly/server-sdk-shared-tests": "@dev",
2827
"phpunit/phpunit": "^9"
2928
},
3029
"autoload": {

php-server-sdk-shared-tests/.circleci/config.yml

Lines changed: 0 additions & 37 deletions
This file was deleted.

php-server-sdk-shared-tests/.gitignore

Lines changed: 0 additions & 4 deletions
This file was deleted.

php-server-sdk-shared-tests/LICENSE.txt

Lines changed: 0 additions & 13 deletions
This file was deleted.

php-server-sdk-shared-tests/README.md

Lines changed: 0 additions & 31 deletions
This file was deleted.

php-server-sdk-shared-tests/composer.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

php-server-sdk-shared-tests/phpunit.xml

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)