(3.0) remove Winston dependency, use SDK's logger (#17)

Author: eli-darkly

dynamodb_feature_store.js

@@ -1,5 +1,4 @@
 var AWS = require('aws-sdk');
-var winston = require('winston');
 
 var helpers = require('./dynamodb_helpers');
 var CachingStoreWrapper = require('launchdarkly-node-server-sdk/caching_store_wrapper');
@@ -11,19 +10,17 @@ function DynamoDBFeatureStore(tableName, options) {
   if (ttl === null || ttl === undefined) {
     ttl = defaultCacheTTLSeconds;
   }
-  return new CachingStoreWrapper(dynamoDBFeatureStoreInternal(tableName, options), ttl, 'DynamoDB');
+  return config =>
+    new CachingStoreWrapper(
+      dynamoDBFeatureStoreInternal(tableName, options, config.logger),
+      ttl,
+      'DynamoDB'
+    );
 }
 
-function dynamoDBFeatureStoreInternal(tableName, options) {
+function dynamoDBFeatureStoreInternal(tableName, options, sdkLogger) {
   options = options || {};
-  var logger = (options.logger ||
-    new winston.Logger({
-      level: 'info',
-      transports: [
-        new (winston.transports.Console)(),
-      ]
-    })
-  );
+  var logger = options.logger || sdkLogger;
   var dynamoDBClient = options.dynamoDBClient || new AWS.DynamoDB.DocumentClient(options.clientOptions);
   var prefix = options.prefix || '';
 

index.d.ts

@@ -56,7 +56,7 @@ declare module 'launchdarkly-node-server-sdk-dynamodb' {
 
     /**
      * A logger to be used for warnings and errors generated by the feature store. If not specified,
-     * the default is an instance of winston.Logger.
+     * it will use the SDK's logging configuration.
      */
     logger?: LDLogger;
   }

package.json

@@ -33,8 +33,7 @@
     "transformIgnorePatterns": []
   },
   "dependencies": {
-    "node-cache": "4.2.0",
-    "winston": "2.4.1"
+    "node-cache": "4.2.0"
   },
   "peerDependencies": {
     "aws-sdk": "^2.349.0",

tests/dynamodb_feature_store-test.js

@@ -25,6 +25,8 @@ describe('DynamoDBFeatureStore', function() {
 
   var table = 'test-store';
 
+  const sdkConfig = { logger: stubLogger() };
+
   beforeAll(function(done) {
     dynamodb.describeTable({ TableName: table }, function(err) {
       if (!err) {
@@ -93,15 +95,15 @@ describe('DynamoDBFeatureStore', function() {
   }
 
   function makeStore() {
-    return new DynamoDBFeatureStore(table);
+    return DynamoDBFeatureStore(table)(sdkConfig);
   }
 
   function makeStoreWithoutCache() {
-    return new DynamoDBFeatureStore(table, {cacheTTL: 0});
+    return DynamoDBFeatureStore(table, {cacheTTL: 0})(sdkConfig);
   }
 
   function makeStoreWithPrefix(prefix) {
-    return new DynamoDBFeatureStore(table, {prefix: prefix, cacheTTL: 0});
+    return DynamoDBFeatureStore(table, {prefix: prefix, cacheTTL: 0})(sdkConfig);
   }
 
   function makeStoreWithDefaultPrefix() {
@@ -139,7 +141,7 @@ describe('DynamoDBFeatureStore', function() {
     beforeEach(() => {
       client = {};
       logger = stubLogger();
-      store = new DynamoDBFeatureStore(table, { dynamoDBClient: client, logger: logger });
+      store = DynamoDBFeatureStore(table, { dynamoDBClient: client })({ logger });
     });
 
     it('error from query in init', done => {