bug fix from master

fix bug when end() called (@aselectroworks)
callback with deviceName (@MicroMidi)

Author: lathoub

src/BLEMIDI_Transport.h

@@ -184,6 +184,7 @@ class BLEMIDI_Transport
     // callbacks
     void (*_connectedCallback)() = nullptr;
     void (*_disconnectedCallback)() = nullptr;
+    void (*_connectedCallbackDeviceName)(char *) = nullptr;
 
     BLEMIDI_Transport &setName(const char *deviceName)
     {
@@ -198,6 +199,12 @@ class BLEMIDI_Transport
         return *this;
     }
 
+    BLEMIDI_Transport &setHandleConnected(void (*fptr)(char*))
+    {
+        _connectedCallbackDeviceName= fptr;
+        return *this;
+    }
+    
     BLEMIDI_Transport &setHandleDisconnected(void (*fptr)())
     {
         _disconnectedCallback = fptr;

src/hardware/BLEMIDI_Client_ESP32.h

@@ -196,6 +196,8 @@ class BLEMIDI_Client_ESP32
     BLERemoteService *pSvc = nullptr;
     bool firstTimeSend = true; // First writeValue get sends like Write with reponse for clean security flags. After first time, all messages are send like WriteNoResponse for increase transmision speed.
 
+    char connectedDeviceName[24];
+
     BLEMIDI_Transport<class BLEMIDI_Client_ESP32<_Settings>, _Settings> *_bleMidiTransport = nullptr;
 
     bool specificTarget = false;
@@ -217,11 +219,9 @@ class BLEMIDI_Client_ESP32
         myAdvCB.enableConnection = false;
         xQueueReset(mRxQueue);
         _client->disconnect();
-        bool success = !_client->isConnected();
-        if (success)
-            _client = nullptr;
+        _client = nullptr;
 
-        return success;
+        return true;
     }
 
     void write(uint8_t *data, uint8_t length)
@@ -270,6 +270,13 @@ class BLEMIDI_Client_ESP32
         if (_bleMidiTransport->_connectedCallback)
             _bleMidiTransport->_connectedCallback();
         firstTimeSend = true;
+
+        if (_bleMidiTransport->_connectedCallbackDeviceName)
+        {
+            sprintf(connectedDeviceName, "%s", myAdvCB.advDevice.getName().c_str());
+            _bleMidiTransport->_connectedCallbackDeviceName(connectedDeviceName);
+        }
+
     }
 
     void disconnected()

src/hardware/BLEMIDI_ESP32_NimBLE.h

@@ -124,6 +124,27 @@ bool BLEMIDI_ESP32_NimBLE<_Settings>::begin(const char *deviceName, BLEMIDI_Tran
 
     BLEDevice::init(deviceName);
 
+    /**
+     * Set the IO capabilities of the device, each option will trigger a different pairing method.
+     *  BLE_HS_IO_DISPLAY_ONLY    - Passkey pairing
+     *  BLE_HS_IO_DISPLAY_YESNO   - Numeric comparison pairing
+     *  BLE_HS_IO_NO_INPUT_OUTPUT - DEFAULT setting - just works pairing
+     */
+    // NimBLEDevice::setSecurityIOCap(BLE_HS_IO_DISPLAY_ONLY); // use passkey
+    // NimBLEDevice::setSecurityIOCap(BLE_HS_IO_DISPLAY_YESNO); //use numeric comparison
+
+    /**
+     *  2 different ways to set security - both calls achieve the same result.
+     *  no bonding, no man in the middle protection, BLE secure connections.
+     *
+     *  These are the default values, only shown here for demonstration.
+     */
+    // NimBLEDevice::setSecurityAuth(false, false, true);
+
+//    NimBLEDevice::setSecurityAuth(/*BLE_SM_PAIR_AUTHREQ_BOND | BLE_SM_PAIR_AUTHREQ_MITM |*/ BLE_SM_PAIR_AUTHREQ_SC);
+
+    NimBLEDevice::setSecurityAuth(true, false, false);
+
     // To communicate between the 2 cores.
     // Core_0 runs here, core_1 runs the BLE stack
     mRxQueue = xQueueCreate(_Settings::MaxBufferSize, sizeof(uint8_t));
@@ -145,8 +166,8 @@ bool BLEMIDI_ESP32_NimBLE<_Settings>::begin(const char *deviceName, BLEMIDI_Tran
 
     _characteristic->setCallbacks(new MyCharacteristicCallbacks<_Settings>(this));
 
-    auto _security = new NimBLESecurity();
-    _security->setAuthenticationMode(ESP_LE_AUTH_BOND);
+//    auto _security = new NimBLESecurity();
+//    _security->setAuthenticationMode(ESP_LE_AUTH_BOND);
 
     // Start the service
     service->start();