Skip to content

Commit ab77eb5

Browse files
committed
TODO
1 parent 3fa23eb commit ab77eb5

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

larray_editor/arraymodel.py

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,19 @@
1313

1414
# TODO before first release:
1515
# * add tests for reliable/"supported" adapters
16+
# * cleanup RecordBatchFileReader (commented code)
17+
# * cleanup commit message
18+
1619

1720
# TODO before using the widget in other projects:
21+
# * cleanup adapter filters API:
22+
# - get_filter_options works for either larray-style filters and
23+
# hlabel filters but cannot work for both at the same time (what the given
24+
# index means).
25+
# - How does axis filters enter the picture?
26+
# - I think we should go towards get_hlabel_actions(row_idx, col_idx) ->
27+
# {'filters': ..., 'sort': ...}.
28+
# this would also help support custom actions: "groupby", ...
1829
# * move ndigits/format detection to adapter
1930
# but the trick is to avoid using current column width and just
2031
# target a "reasonable number" of digits
@@ -81,7 +92,6 @@
8192
# superclass or one of their subclasses)
8293

8394
# TODO post release (move to issues):
84-
# * take decoration (sort arrow) into account to compute column widths
8595
# * mouse selection on "edges" should move the buffer
8696
# (it scrolls the internal viewport but does not change the offset)
8797

0 commit comments

Comments
 (0)