Refactor policies to remove unnecessary user parameters in viewAny and create methods

Author: laravelwebdev

app/Nova/KerangkaAcuan.php

@@ -14,7 +14,6 @@
 use App\Nova\Metrics\MetricValue;
 use Illuminate\Database\Eloquent\Model;
 use Laravel\Nova\Fields\BelongsTo;
-use Laravel\Nova\Fields\BelongsToMany;
 use Laravel\Nova\Fields\Boolean;
 use Laravel\Nova\Fields\Date;
 use Laravel\Nova\Fields\FormData;
@@ -135,7 +134,6 @@ public function fields(NovaRequest $request)
                     $query->has('daftarSp2d', '<=', $value);
                 })
                 ->onlyOnIndex(),
-            BelongsToMany::make('SP2D', 'daftarSp2d', 'App\Nova\DaftarSp2d'),
             Tab::group('Detail', [
                 HasMany::make('Anggaran', 'anggaranKerangkaAcuan', 'App\Nova\AnggaranKerangkaAcuan'),
                 HasMany::make('Spesifikasi', 'spesifikasiKerangkaAcuan', 'App\Nova\SpesifikasiKerangkaAcuan'),

app/Policies/KerangkaAcuanPolicy.php

@@ -12,7 +12,7 @@ class KerangkaAcuanPolicy
     /**
      * Determine whether the user can view any models.
      */
-    public function viewAny(User $user): bool
+    public function viewAny(): bool
     {
         return Policy::make()
             ->notAllowedFor('admin')
@@ -33,7 +33,7 @@ public function view(User $user, KerangkaAcuan $kerangkaAcuan): bool
     /**
      * Determine whether the user can create models.
      */
-    public function create(User $user): bool
+    public function create(): bool
     {
         return Policy::make()
             ->allowedFor('koordinator,anggota')
@@ -90,19 +90,4 @@ public function runAction(User $user, KerangkaAcuan $kerangkaAcuan): bool
             ->withYear(Helper::getYearFromDate($kerangkaAcuan->tanggal))
             ->get();
     }
-
-    public function attachDaftarSp2d()
-    {
-        return false;
-    }
-
-    public function attachAnyDaftarSp2d()
-    {
-        return false;
-    }
-
-    public function detachDaftarSp2d()
-    {
-        return false;
-    }
 }

app/Policies/PersediaanKeluarPolicy.php

@@ -12,7 +12,7 @@ class PersediaanKeluarPolicy
     /**
      * Determine whether the user can view any models.
      */
-    public function viewAny(User $user): bool
+    public function viewAny(): bool
     {
         return Policy::make()
             ->allowedFor('bmn')
@@ -33,7 +33,7 @@ public function view(User $user, PersediaanKeluar $persediaanKeluar): bool
     /**
      * Determine whether the user can create models.
      */
-    public function create(User $user): bool
+    public function create(): bool
     {
         return Policy::make()
             ->allowedFor('bmn')

app/Policies/PersediaanMasukPolicy.php

@@ -12,7 +12,7 @@ class PersediaanMasukPolicy
     /**
      * Determine whether the user can view any models.
      */
-    public function viewAny(User $user): bool
+    public function viewAny(): bool
     {
         return Policy::make()
             ->allowedFor('bmn')
@@ -33,7 +33,7 @@ public function view(User $user, PersediaanMasuk $persediaanMasuk): bool
     /**
      * Determine whether the user can create models.
      */
-    public function create(User $user): bool
+    public function create(): bool
     {
         return Policy::make()
             ->allowedFor('bmn')