📈 ajout de phpstan pour la validation statique du code

Author: mckenziearts

.gitignore

@@ -43,6 +43,7 @@ Homestead.json
 Homestead.yaml
 .phpstorm.meta.php
 _ide_helper.php
+_ide_helper_models.php
 
 # OSX
 #

app/Actions/Fortify/CreateNewUser.php

@@ -16,7 +16,7 @@ class CreateNewUser implements CreatesNewUsers
     /**
      * Validate and create a newly registered user.
      *
-     * @param  array  $input
+     * @param  array  $input<string, string>
      * @return \App\Models\User
      *
      * @throws \Illuminate\Validation\ValidationException

app/Actions/Fortify/PasswordValidationRules.php

@@ -9,7 +9,7 @@ trait PasswordValidationRules
     /**
      * Get the validation rules used to validate passwords.
      *
-     * @return array
+     * @return array<int, \Illuminate\Validation\Rules\Password|string>
      */
     protected function passwordRules(): array
     {

app/Actions/Fortify/ResetUserPassword.php

@@ -14,7 +14,7 @@ class ResetUserPassword implements ResetsUserPasswords
      * Validate and reset the user's forgotten password.
      *
      * @param  mixed  $user
-     * @param  array  $input
+     * @param  array  $input<string string>
      * @return void
      *
      * @throws \Illuminate\Validation\ValidationException

app/Actions/Fortify/UpdateUserProfileInformation.php

@@ -13,7 +13,7 @@ class UpdateUserProfileInformation implements UpdatesUserProfileInformation
      * Validate and update the given user's profile information.
      *
      * @param  mixed  $user
-     * @param  array  $input
+     * @param  array  $input<string, string>
      * @return void
      *
      * @throws \Illuminate\Validation\ValidationException

app/Console/Commands/Cleanup/DeleteOldUnverifiedUsers.php

@@ -12,16 +12,18 @@ class DeleteOldUnverifiedUsers extends Command
 
     protected $description = 'Removed all unverified users.';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Deleting old unverified users...');
 
         $query = User::query()
             ->whereNull('email_verified_at')
             ->where('created_at', '<', now()->subDays(10));
 
-        if ($query->get()->isNotEmpty()) {
-            foreach ($query->get() as $user) {
+        $users = $query->get();
+
+        if ($users->isNotEmpty()) {
+            foreach ($users as $user) {
                 $user->notify((new SendEMailToDeletedUser())->delay(now()->addMinutes(5)));
             }
         }

app/Console/Commands/CreateAdminUser.php

@@ -2,27 +2,18 @@
 
 namespace App\Console\Commands;
 
+use App\Models\User;
 use Illuminate\Console\Command;
 use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Hash;
 
 class CreateAdminUser extends Command
 {
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
     protected $signature = 'lcm:admin';
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Create user with admin role and all permissions.';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Create Admin User.');
         $this->createUser();
@@ -51,10 +42,9 @@ protected function createUser(): void
             'password' => Hash::make($password),
             'email_verified_at' => now()->toDateTimeString(),
         ];
-        $model = config('auth.providers.users.model');
 
         try {
-            $user = tap((new $model)->forceFill($userData))->save();
+            $user = User::query()->create($userData);
 
             $user->assignRole('admin');
         } catch (\Exception | QueryException $e) {

app/Console/Commands/UpdateUserDiscussionsPoints.php

@@ -17,6 +17,7 @@ public function handle()
         $this->info('Updating users discussions reputations...');
 
         foreach (Discussion::all() as $discussion) {
+            // @phpstan-ignore-next-line
             givePoint(new DiscussionCreated($discussion), $discussion->author);
         }
 

app/Console/Commands/UpdateUserPostsPoints.php

@@ -16,7 +16,8 @@ public function handle()
     {
         $this->info('Updating users posts reputations...');
 
-        foreach (Article::all() as $article) {
+        foreach (Article::published()->get() as $article) {
+            // @phpstan-ignore-next-line
             givePoint(new PostCreated($article), $article->author);
         }
 

app/Console/Commands/UpdateUserThreadsPoints.php

@@ -17,6 +17,7 @@ public function handle()
         $this->info('Updating users threads reputations...');
 
         foreach (Thread::all() as $thread) {
+            // @phpstan-ignore-next-line
             givePoint(new ThreadCreated($thread), $thread->author);
         }