shouldBeSearchable is not called during processing of MakeSearchable

[aleem-dubizzlelabs]

Scout Version

10.1.0

Scout Driver

Typesense

Laravel Version

9

PHP Version

8.1

Database Driver & Version

No response

SDK Version

No response

Meilisearch CLI Version

No response

Description

Laravel Scout is syncing all User model records even though the shouldBeSearchable() method is defined to filter them. The method is being ignored because searchable() is called on the full collection (User::all()), which bypasses the shouldBeSearchable() logic.

Steps To Reproduce

Define a shouldBeSearchable() method in your model (e.g., User):

public function shouldBeSearchable()
{
    return $this->is_active;
}

Run this code to sync the models:

User::all()->searchable();
Observe that all users are indexed, including those where is_active = false.

[jackbayliss]

This is already highlighted in the docs afaik searchable overrides it:
https://laravel.com/docs/12.x/scout#conditionally-searchable-model-instances

[chack1172]

But what is the reason behind this? Why shouldBeSearchable() is only checked when using query builder and not in collection?
If I manually make searchable a model that shouldn't be searched, it will be removed on the next model update, no?

Looking at

scout/src/SearchableScope.php

Line 38 in 36ff09e

$models->filter->shouldBeSearchable()->searchable();

The same behavior can be achieved moving the filter in https://github.com/laravel/scout/blob/10.x/src/Searchable.php inside the queueMakeSearchable() and syncMakeSearchable() methods.