Fix linting with build files

Author: timacdonald

eslint.config.mjs renamed to eslint.config.js

@@ -1,49 +1,53 @@
-import typescriptEslint from '@typescript-eslint/eslint-plugin'
-import stylistic from '@stylistic/eslint-plugin'
 import globals from 'globals'
+import pluginJs from '@eslint/js'
+import pluginReact from 'eslint-plugin-react'
+import pluginTs from 'typescript-eslint'
+import pluginVue from 'eslint-plugin-vue'
+import stylistic from '@stylistic/eslint-plugin'
 import tsParser from '@typescript-eslint/parser'
-import path from 'node:path'
-import { fileURLToPath } from 'node:url'
-import js from '@eslint/js'
-import { FlatCompat } from '@eslint/eslintrc'
-
-const __filename = fileURLToPath(import.meta.url)
-const __dirname = path.dirname(__filename)
-const compat = new FlatCompat({
-    baseDirectory: __dirname,
-    recommendedConfig: js.configs.recommended,
-    allConfig: js.configs.all,
-})
+import typescriptEslint from '@typescript-eslint/eslint-plugin'
 
 export default [
-    ...compat.extends('eslint:recommended', 'plugin:@typescript-eslint/recommended'),
     {
-        plugins: {
-            '@typescript-eslint': typescriptEslint,
-            '@stylistic': stylistic,
-        },
+        files: ['**/*.{js,jsx,mjs,cjs,ts,tsx}'],
+        ignores: ['**/dist/**'],
 
         languageOptions: {
-            globals: {
-                ...globals.browser,
-                ...globals.node,
+            globals: globals.browser,
+            parser: tsParser,
+        },
+
+        settings: {
+            react: {
+                version: '18',
             },
+        },
 
-            parser: tsParser,
+        plugins: {
+            'js': pluginJs,
+            'react': pluginReact,
+            'vue': pluginVue,
+            '@stylistic': stylistic,
+            '@typescript-eslint': typescriptEslint,
         },
 
         rules: {
-            quotes: ['error', 'single'],
+            ...pluginJs.configs.recommended.rules,
+            ...pluginTs.configs.recommended.reduce((carry, config) => ({ ...carry, ...config.rules }), {}),
+            ...pluginReact.configs.flat.recommended.rules,
+            ...pluginVue.configs['flat/recommended'].reduce((carry, config) => ({ ...carry, ...config.rules }), {}),
+            'quotes': ['error', 'single'],
             'no-trailing-spaces': ['error'],
             'object-curly-spacing': ['error', 'always'],
             'comma-dangle': ['error', 'always-multiline'],
-            semi: ['error', 'never'],
+            'semi': ['error', 'never'],
             '@typescript-eslint/no-non-null-assertion': ['off'],
             '@typescript-eslint/ban-ts-comment': ['off'],
             '@typescript-eslint/no-explicit-any': ['off'],
             '@stylistic/no-extra-semi': ['error'],
             '@stylistic/arrow-parens': ['error'],
             '@stylistic/space-infix-ops': ['error'],
+            '@stylistic/indent': ['error', 4],
         },
     },
 ]

package.json

@@ -1,5 +1,6 @@
 {
     "private": true,
+    "type": "module",
     "workspaces": [
         "packages/core",
         "packages/react",
@@ -13,8 +14,7 @@
         "build": "npm run build --workspaces",
         "link": "npm link --workspaces",
         "typeCheck": "npm run typeCheck --workspaces",
-        "lint": "eslint --ignore-pattern /packages/**/dist/** ./packages/**",
-        "lint:fix": "eslint --fix --ignore-pattern /packages/**/dist/** ./packages/**",
+        "lint": "eslint",
         "test": "npm run test --workspaces --if-present"
     },
     "devDependencies": {
@@ -24,6 +24,9 @@
         "@typescript-eslint/eslint-plugin": "^8.3.0",
         "@typescript-eslint/parser": "^8.3.0",
         "eslint": "^9.9.1",
-        "globals": "^15.9.0"
+        "eslint-plugin-react": "^7.35.2",
+        "eslint-plugin-vue": "^9.28.0",
+        "globals": "^15.9.0",
+        "typescript-eslint": "^8.4.0"
     }
 }

packages/core/src/validator.ts

@@ -37,7 +37,7 @@ export const createValidator = (callback: ValidationCallback, initialData: Recor
             return listeners.validatingChanged
         }
 
-         return []
+        return []
     }
 
     /**
@@ -315,7 +315,7 @@ export const createValidator = (callback: ValidationCallback, initialData: Recor
             setTouched([name, ...touched]).forEach((listener) => listener())
         }
 
-         validator(config ?? {})
+        validator(config ?? {})
     }
 
     /**

packages/core/tests/validator.test.js

@@ -436,9 +436,9 @@ it('revalidates when touched changes', async () => {
     expect.assertions(1)
 
     let requests = 0
-    let resolvers = []
-    let promises = []
-    let configs = []
+    const resolvers = []
+    const promises = []
+    const configs = []
     axios.request.mockImplementation((c) => {
         requests++
         configs.push(c)
@@ -471,7 +471,7 @@ it('can validate without needing to specify a field', async () => {
 
         return Promise.resolve(precognitionSuccessResponse())
     })
-    let data = { name: 'Tim', framework: 'Laravel' }
+    const data = { name: 'Tim', framework: 'Laravel' }
     const validator = createValidator((client) => client.post('/foo', data))
 
     validator.touch(['name', 'framework']).validate()
@@ -624,7 +624,7 @@ it('uses the lastest config values', async () => {
 })
 
 it('does not cancel submit requests', async () => {
-    let data = {}
+    const data = {}
     let submitConfig
     let validateConfig
     axios.request.mockImplementation((config) => {
@@ -650,10 +650,10 @@ it('does not cancel submit requests', async () => {
 })
 
 it('does not cancel submit requests with custom abort signal', async () => {
-    let data = {}
+    const data = {}
     let submitConfig
     let validateConfig
-    let abortController = new AbortController
+    const abortController = new AbortController
     axios.request.mockImplementation((config) => {
         if (config.precognitive) {
             validateConfig = config