Misleading types in PHPDoc blocks or not detailed information

[alies-dev]

• Nova Version: 4.29.4

Description:

\Laravel\Nova\Fields\HasDownload::download

/**
 * Specify the callback that should be used to create a download HTTP response.
 *
- * @param callable(\Laravel\Nova\Http\Requests\NovaRequest, \Laravel\Nova\Resource, ?string, ?string):mixed $downloadResponseCallback
+ * @param callable(\Laravel\Nova\Http\Requests\NovaRequest, \Illuminate\Database\Eloquent\Model, ?string, ?string):mixed $downloadResponseCallback
 * @return $this
 */
public function download(callable $downloadResponseCallback)

but ideally the trait should use a @template syntax: @template TModel of \Illuminate\Database\Eloquent\Model:

@param callable(\Laravel\Nova\Http\Requests\NovaRequest, TModel, ?string, ?string):mixed  

\Laravel\Nova\Actions\Action

Use conditional return types for methods that use func_num_args:

    /**
     * Return a dangerous message response from the action.
     *
     * @param string $name
     * @param string|null $message
     * @psalm-return (func_num_args() is 2
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function danger($name, string $message = null)
    {
    }


    /**
     * Return a redirect response from the action.
     *
     * @param string $name
     * @param string|null $url
     * @psalm-return (func_num_args() is 2
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function redirect($name, $url = null)
    {
    }

    /**
     * Return a Inertia visit from the action.
     * @deprecated Use "visit"
     *
     * @param string $name
     * @param string $path
     * @param array<string, mixed> $options
     * @psalm-return (func_num_args() is 3
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function push($name, $path, $options = [])
    {
    }

    /**
     * Return a Inertia visit from the action.
     *
     * @param string $name
     * @param string|array<string, mixed> $path
     * @param array<string, mixed> $options
     * @psalm-return (func_num_args() is 3
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function visit($name, $path = [], $options = [])
    {
    }
    /**
     * Return a download response from the action.
     *
     * @param string $name
     * @param string $url
     * @psalm-return (func_num_args() is 2
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function downloadURL($name, $url)
    {
    }

    /**
     * Return an action modal response from the action.
     *
     * @param string $name
     * @param string|array<string, mixed> $modal
     * @param array<string, mixed> $data
     * @psalm-return (func_num_args() is 3
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function modal($name, $modal = [], $data = [])
    {
    }

    /**
     * Return an open in new tab response from the action.
     *
     * @param string $name
     * @param string|null $url
     * @psalm-return (func_num_args() is 2
     *  ? static
     *  : \Laravel\Nova\Actions\ActionResponse
     * )
     */
    public static function openInNewTab($name, $url = null)
    {
    }

These changes will help static analysis tools (Psalm and PHPStan) a lot.