Non performant numeric ID search

[Norgul]

Hello, I am using Nova v3 and just noticed that searching by ID is including one extra query.

// vendor/laravel/nova/src/PerformsQueries.php

protected static function applySearch($query, $search)
{
    return $query->where(function ($query) use ($search) {
        // ...
        if ($canSearchPrimaryKey) {
           $query->orWhere($model->getQualifiedKeyName(), $search);
        }
        //...
       foreach (static::searchableColumns() as $column) {
            $query->orWhere(...);
        }
    });
}

So if you forward 15 in the UI, it will execute

WHERE id = 15 or id like '%15%' instead of just the first case.

To circumvent, I added a simple if clause:

foreach (static::searchableColumns() as $column) {

    if ($column === $model->getKeyName()) {
        continue;
    }

    $query->orWhere(...);
}

[crynobone]

This is no longer the behavior in Laravel Nova 4. However, this wouldn't be fixed in Laravel Nova 3 as we no longer making any new releases for that version.