No information about selected resources or applied filters in action fields() when selecting "all matching" resources

[mattias-sanfridsson]

• Laravel Version: 9.52.4
• Nova Version: 4.22.1
• PHP Version: 8.1.14
• Database Driver & Version: MySQL 8.0
• Operating System and Version: MacOS Ventura 13.2.1
• Browser type and version: Chrome 110.0.5481.100
• Reproduction Repository: -

Description:

Selecting all when having a filter applied will only give the request the following data in an action's field method:

{"relationshipType":null,"display":"index","resources":"all"}

Whereas selecting specific resources will give the resource IDs:

{"relationshipType":null,"display":"index","resources":["33545","33544"]}

Since there's no detail about what filter has been applied it's impossible to filter the action field data based on the selected resources. $request->selectedResources() will also return null.

The filter I'm using is a default BelongsTo:

BelongsTo::make(__('Company'), 'company', Company::class)->filterable(),

And the code I'm using to log the data in the action's field method looks like this:

public function fields(NovaRequest $request): array
{
    info('request', $request->all());

    return [];
}

Detailed steps to reproduce the issue on a fresh Nova installation:

• Set up a resource with a belongsto field that is filterable.
• Set up an action that logs the incoming request data in the fields() method.
• Go to the list, apply the filter and select all matching.
• Compare the log with selecting specific resources and opening the action.

[crynobone]

The filters information should be available from $request->query().

[mattias-sanfridsson]

@crynobone But wouldn't it make sense to at least include the applied filter somehow? Right now there's a risk that a change would be applied on all resources, not the filtered ones because there's no information about the filter in the request.

[crynobone]

Filtered information is not being used by Nova on those requests, so it isn't useful for us. Also, the value is only useful when the value is mapped to the query (not for this request).

[mattias-sanfridsson]

But if you apply a filter you can select all matching resources and then run an action on them?

[crynobone]

But if you apply a filter you can select all matching resources and then run an action on them?

Action selection and Running actions are two different requests.

[mattias-sanfridsson]

Ok so I'll draw the conclusion that it's impossible to know what resources are filtered in the fields method then :)