BelongsTo field resets after changing value when depends on itself

[kusab85]

• Laravel Version: 9.45.1
• Nova Version: 4.19.5 (Silver Surfer)
• PHP Version: 8.0.11
• Database Driver & Version: SQL lite
• Operating System and Version: Windows 10 22H2
• Browser type and version: FF, Chrome
• Reproduction Repository: https://github.com/kusab85/TestApp/tree/nova-BelongsTo-resets-with-dependsOn

Description:

Value of BelongsTo field resets to its initial value when dependsOn itself.

/**
 * App/Nova/Post.php 
 */

    public function fields(NovaRequest $request)
    {
        return [
            // [...]
            BelongsTo::make('User')
                ->dependsOn(
                    ['user'],
                    function (BelongsTo $field, NovaRequest $request, FormData $formData) {
                        $field->help(
                            '$formData->user = '.var_export($formData->user, true).' '.
                            '$field->value = '.var_export($field->value, true)
                        );
                    }),
           // [...]
        ];
    }

1. Initial state of form field

2. Selecting a new user

3. Form field state after new user selection

Detailed steps to reproduce the issue on a fresh Nova installation:

Check reproduction repository.

[crynobone]

Yes, this is the expected behavior to avoid the initial default being populated and only consider $field->value assigned via dependsOn()

[kusab85]

I don't assign nor want to assign any value. I just want to set fields help text according to value change made manually by a user.
Just look at the example above. I select "Chadrick Mante" (whose ID is 7) but fields display value is set back to "Mossie Mayer".

[crynobone]

Sorry but Dependent Field shouldn't listen to self, that just never considered.

[kusab85]

But it worked as I expected prior to 4.19.3 version.
I think the fix of issue where BelongsTo fields weren't broadcasting their changes changed fields behavior.

[crynobone]

It was never designed to work as you described.

[kusab85]

Ok, what can I say? I'll find a way around. ;-)

[ghost]

@kusab85 have you found a way around? :)

[ghost]

I have the exact same use case. And by the way listening to the field itself work fine with Text fields and I believe for Select fields as well.

[crynobone]

There were some significant changes on Dependent Fields for the last few patch releases so it could be possible. Still, it sure is not a behavior we cover when implementing this feature.

As long as depending on self and not doing any $field->setValue() you should be fine.

[ghost]

Thanks @crynobone! The issue I'm experiencing right now is that when selecting an option from the creation form, Nova shows the loading indicator (green line on top of the screen) and clears the select field. On the edit form it's even worse - it reloads the field indefinitely (the loading indicator is shown and bunch of ajax requests are sent in an infinite loop). The same thing happens when dependsOn() callback is entirely empty.

I'm on v4.25.1.

public static function make(): BelongsTo
{
    return BelongsTo::make(__('Work Order Type'), 'workOrderType', WorkOrderTypeResource::class)
        ->dependsOn(
            'workOrderType',
            function (BelongsTo $field, NovaRequest $request, FormData $formData) {
                if (! $formData->workOrderType) {
                    return;
                }

                $workOrderType = WorkOrderType::query()->find($formData->workOrderType);
                $field->help($workOrderType->description);
            }
        );
}

[crynobone]

In that case it not possible at the moment.

[crynobone]

You should be able to depends on self in 4.26.0

[kusab85]

Hooray!

[kusab85]

But is this behavior meant to be permanent feature, @crynobone ? ;-)