Resource is not binded when updating dependent fields

[xel1045]

• Laravel Version: 9.27.0
• Nova Version: 4.14.3
• PHP Version: 8.1.9
• Database Driver & Version: MySQL 8.0.30
• Operating System and Version: macOS 12.6
• Browser type and version: Chrome 105

Description:

When updating an existing resource, Laravel doesn't bind the resource when applying dependent fields.

To be more specific, when the fields method is call for a request to /nova-api/resource/id/update-fields, the $this->resource model is empty. In my case, it looks like this:

It seems that \Laravel\Nova\Http\Controllers\UpdateFieldController::sync was modified in Nova 4.2.4 and it doesn't use the binded resource.

Right now it looks like this:

    public function sync(ResourceUpdateOrUpdateAttachedRequest $request)
    {
        UpdateViewResource::make()->newResourceWith($request);

        return response()->json(
            $request->newResource()
                ->updateFields($request)

But I think it should be this instead:

    public function sync(ResourceUpdateOrUpdateAttachedRequest $request)
    {
        $resource = UpdateViewResource::make()->newResourceWith($request);

        return response()->json(
            $resource
                ->updateFields($request)

Detailed steps to reproduce the issue on a fresh Nova installation:

1. Create a resources with dependents fields
2. Add a breakpoint on the fields method when update-fields on edit (condition str_contains($request->url(), 'update-fields'))
3. Change a dependent field to trigger an update
4. When your breakpoint is reached, check the current value of the $this->resource

Thanks!

[crynobone]

This is the current expected behaviour, as loading the resources on each sync could be a performance bottleneck for the app. Marking this as a feature request for now.

[xel1045]

We have a "Province / State" select field which depends on the selected country and is readonly on edit if the model was manually created through the admin. Unfortunately, the readonly state is lost when options are loaded.

[crynobone]

Can you provide a code example for the use case?

[xel1045]

Unfortunately, I don't have a public repository for this, but the code looks like this:

class Donation {
    public function fields(): array
    {
        return [
            // ...

            Select::make('State', 'state_id')
                    ->dependsOn('country_id', function (Select $field, NovaRequest $request, FormData $formData) {
                        if (! $countryId = $formData->get('country_id')) {
                            return;
                        }

                        $country = Country::query()->findOrFail($countryId);
                        $states = $country->states()->pluck('name', 'id');

                        $field
                            ->options($states)
                            ->readonly(! $this->resource->exists || $this->resource->is_manually_created)
                            ->rules([
                                'required',
                                'integer',
                                Rule::in($states->keys()),
                            ]);
                    })
                    ->displayUsingLabels()
                    ->readonly(),

            // ...
        ];
    }
}

Right now, our workaround is to load the resource when it's not loaded in update requests, but this loads the model twice (in \Laravel\Nova\Http\Controllers\UpdateFieldController::sync and in our method isManuallyCreated) and this is really hacky:

    /**
     * @param \Laravel\Nova\Http\Requests\NovaRequest $request
     * @return bool
     */
    protected function isManuallyCreated(NovaRequest $request): bool
    {
        $resource = $this->resource;

        // When creating a donation, we can assume it's manually created
        if ($request->isUpdateOrUpdateAttachedRequest()) {
            $resource = once(fn () => $resource->exists ? $resource : $request->findModel());
        }

        return ! $resource->exists || $resource->is_manually_created;
    }

As mentioned, it was working prior to Nova 4.2.4.

Thanks!

[crynobone]

Personally I would use:

class Donation {
    public function fields(): array
    {
        return [
            // ...
            Hidden::make('Is Manually Created', 'is_manually_created'),
            Select::make('State', 'state_id')
                    ->dependsOn(['country_id', 'is_manually_created'], function (Select $field, NovaRequest $request, FormData $formData) {
                        if (! $countryId = $formData->get('country_id')) {
                            return;
                        }

                        $country = Country::query()->findOrFail($countryId);
                        $states = $country->states()->pluck('name', 'id');

                        $field
                            ->options($states)
                            ->readonly(! $formData->is_manually_created)
                            ->rules([
                                'required',
                                'integer',
                                Rule::in($states->keys()),
                            ]);
                    })
                    ->displayUsingLabels()
                    ->readonly(),

            // ...
        ];
    }
}

[xel1045]

Indeed, that would work too as a workaround.

[crynobone]

Implemented in 4.16

[xel1045]

Thanks!