You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I saw that there is no callback logic for the showOnPreview() method:
/**
* Show the field in the modal preview.
*
* @return $this
*/
public function showOnPreview()
{
$this->showOnPreview = true;
return $this;
}
And, to keep it consistent with all other similar methods, my suggestion is to add the callback logic to the showOnPreview() method, see the showOnDetail as an example:
/**
* Specify that the element should be hidden from the detail view.
*
* @param (callable():bool)|bool $callback
* @return $this
*/
public function showOnDetail($callback = true)
{
$this->showOnDetail = $callback;
return $this;
}
This would be nice, I missed that feature and hope other devs may miss that too, but the major reason is to keep it consistent ✌️
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello,
I saw that there is no callback logic for the
showOnPreview()method:And, to keep it consistent with all other similar methods, my suggestion is to add the callback logic to the
showOnPreview()method, see theshowOnDetailas an example:This would be nice, I missed that feature and hope other devs may miss that too, but the major reason is to keep it consistent ✌️
Beta Was this translation helpful? Give feedback.
All reactions