Incomplete translations

[martio]

• Laravel Version: 8.25.0
• Nova Version: 3.20.0
• PHP Version: 8.0.1

Description:

Incomplete translation when localization is set to another language in the app config file.

Detailed steps to reproduce the issue on a fresh Nova installation:

FILE: config/app.php

When 'locale' => 'en' is OK:

When 'locale' => 'pl' is INCOMPLETE ("Resouces" label in sidebar and "Create" button):

NovaServiceProvider:

    public function boot()
    {
        parent::boot();

        Nova::serving(function (ServingNova $event) {
            $this->app->setLocale('pl');

            Nova::translations([
                resource_path('lang/vendor/nova/en.json'),
                resource_path('lang/vendor/nova/pl.json'),
            ]);
        });
    }

[crynobone]

This doesn't seem to be correct.

[crynobone]

Based on code review, you shouldn't use the above code since Laravel Nova would already load en.json or pl.json based on locale config.

[f-liva]

It doesn't work for me either, in my case the local language is Italian (it).

Red circles are in English, green circles are in Italian.

So strange...

[martio]

It will work as you set the default language to English:

'locale' => 'en',

in config/app.php

This is bug...

[crynobone]

Loading both en.json and pl.json causes the bug. You should only load language string based on the current locale.

[f-liva]

Nothing changes by setting all language references to IT instead of EN and importing only the IT language.

It still loads half in English and half in Italian.

[martio]

I have the same...

[crynobone]

You can refer reproducing code nova-issues/issue-3239@9bb0a0f

[martio]

@crynobone it doesn't work for me...

    public function boot()
    {
        parent::boot();

        Nova::serving(function (ServingNova $event) {
            $this->app->setLocale((('pl' == $event->request->user()->locale) ? 'pl' : 'en'));

            Nova::translations(
                resource_path("lang/vendor/nova/{$this->app->getLocale()}.json")
            );
        });
    }

    'locale' => 'pl',

[martio]

It's okay when I set in app.php: 'locale' => 'en'

[crynobone]

above code the one causing the issue. See the example project I share above

[f-liva]

@crynobone I didn't understand your request

[henryavila]

What he means, is that the code you added in NovaServiceProvider file manually adding the translation is breaking the app, because nova will automatically handle the translation. See my comment below for more detail.

Also, take a look in docs: https://nova.laravel.com/docs/3.0/customization/localization.html

[henryavila]

The translation is working perfect for me. I use the entire app in 'pt_BR' locale.
You have to do just 3 things:

1. Get the json lang file. I recommend using: https://github.com/coderello/laravel-nova-lang and insert your custom content
2. Put the .json lang file in resources/lang folder
3. in config/app.php, change the locale to the name of your json file

Ps: Nova, automatically handle the translation, so, your code adding the translation is breaking the app. Just do the 3 steps above AND remove your code in NovaServiceProvider that the translation will work perfectly.

[crynobone]

Try to set it up like that:

Still getting the same result, there no bug.

If I give two the same locale, it does not work. How different it works..

This is a usage issue. Something you're doing in your app causing it not to work properly. You need to review what your doing, what packages you include that can cause this issue etc.

[martio]

@crynobone Look here...

https://youtu.be/CBCM7l0GxJw

[crynobone]

@martio I have tried multiple times to reproduce the issue on a default Nova installation and verify that there no bug in the current implementation. I also have tried to explain to you that you need to check your usage that could cause an issue.

You can show me video, screenshot etc but at the end of the day, it's not reproducable. If you can prove that an issue can reproduce please submit a failing code to https://github.com/nova-issues/issue-3239/

[martio]

@crynobone I found a problem! The problem occurs when usign translations in the JetstreamServiceProvider class, in configurePermissions class. It's not the Nova's fault. Sorry! :(

[msucevan]

@crynobone in
php Nova::booted(function () { auth()->user()->language->code; });
return null because is too early to call the authenticated user

[martio]

If the localization is the same as in the provider, there are translation problems...

config/app.php => 'en' and NovaServiceProvider => 'de'

config/app.php => 'de' and NovaServiceProvider => 'de'

NovaServiceProvider.php

        Nova::serving(function (ServingNova $event) {
            app()->setLocale('de');
        });

[henryavila]

@martio, please, do the 3 steps I described and remove your code from app/Providers/NovaServiceProvider.php. It should work.

make sure you have the file resources/lang/pl.json

[martio]

I checked. I have only this:

    'locale' => 'pl',

and "Resources" in the sidebar is not translated...

[f-liva]

I've note JetStream and I still suffer this issue. I don't think JetStream it's the point of fault, there should be an issue with Nova. Everything works fine with translations on Laravel, but not within Nova backed. Can't understand why Il lun 8 mar 2021, 18:10 Marcin Lewandowski <notifications@github.com> ha scritto:

…

@crynobone <https://github.com/crynobone> I found a problem! The problem occurs when usign translations in the JetstreamServiceProvider class, in configurePermissions class. It's not the Nova's fault. Sorry! :( — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3239 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACUQ4HE7DOZWE774UYHK3DTCUAJFANCNFSM4XOACCRQ> .

[martio]

@crynobone @henryavila

I think the problem is with Laravel Nova. See:

1. Put Polish translation to:

resources/lang/vendor/nova/pl.php

2. Set locale in config/app.php

'locale' => 'pl',

3. Set in app/Providers/NovaServiceProvider.php

Nova::booted(function () {
    app()->setLocale('pl');
});

Up to this point is fine...

4. Use translation anywhere in providers...

E.g:

class NovaServiceProvider extends NovaApplicationServiceProvider
{
    public function boot()
    {
        parent::boot();

        Nova::booted(function () {
            app()->setLocale('pl');
        });

        __('messages.welcome');
    }
}

and... translation in admin panel is incomplete...

If I remove what is below it is fine:

__('messages.welcome');

[crynobone]

    public function boot()
    {
        parent::boot();

        Nova::booted(function () {
            app()->setLocale('pl');
        });

        __('messages.welcome');
    }

If you understand the process, you would know how this going to cause issue. __('messages.welcome') will be executed way before Nova::booted() (because booted() will only be executing when nova URI get executed.

Not a bug with Laravel Nova, that just the way you use it causing issue.

[martio]

@crynobone This is an example from Jetstream package. If you are using Laravel Jetstream, the Laravel Nova does not work properly...

app/Providers/JetstreamServiceProvider.php

        Jetstream::role('editor', __('Editor'), [
            'read',
            'create',
            'update',
        ])->description(__('Editor users have the ability to read, create, and update.'));

If I remove the translations from the JetstreamServiceProvider class, it works fine.

How to solve this problem?

[crynobone]

Why are you waiting for Nova booted event to switch locale? That's the whole issue due to your usage. It can't be fixed by Nova or Jetstream

[martio]

@crynobone I set the language by user settings:

    public function boot()
    {
        parent::boot();

        Nova::serving(function (ServingNova $event) {
            app()->setLocale(
                (('pl' == $event->request->user()->locale) ? 'pl' : 'en')
            );
        });
    }

The application has 8 languages and the admin panel only 2.

[ekandreas]

I can confirm the same thing in Swedish.

[msucevan]

@ekandreas, @martio, @crynobone

I think here the best solution is to create a middleware and put it in nova.php before HandleInertiaRequests.

    'middleware' => [
        'web',
        SwitchLanguage::class,
        HandleInertiaRequests::class,
  ],

This because if you use Nova::serving some translation are translated others not, so I think is a little too late.

[crynobone]

Middleware are executed after service providers have been booted. It doesn't solve the issue described by @martio.

[msucevan]

Yes it solves it. Because I had the same problem.

When I used in the boot function Nova::serving translation was translating only a few labels. When I switch to use the middleware in nova.php I didn't have any problem.