Skip to content

Commit 64ece28

Browse files
Test cleanup from #53664 (#53672)
* Correct test names * Strengthen test to enforce alias * Modernize code
1 parent e1db317 commit 64ece28

File tree

1 file changed

+13
-9
lines changed

1 file changed

+13
-9
lines changed

tests/Support/SupportTestingBusFakeTest.php

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ public function testAssertNothingDispatched()
465465
$this->fail();
466466
} catch (ExpectationFailedException $e) {
467467
$this->assertStringContainsString('The following jobs were dispatched unexpectedly:', $e->getMessage());
468-
$this->assertStringContainsString(get_class(new BusJobStub), $e->getMessage());
468+
$this->assertStringContainsString(BusJobStub::class, $e->getMessage());
469469
}
470470
}
471471

@@ -557,9 +557,13 @@ public function testAssertNothingChainedFails()
557557
{
558558
$this->fake->chain([new ChainedJobStub])->dispatch();
559559

560-
$this->expectException(ExpectationFailedException::class);
561-
562-
$this->fake->assertNothingChained();
560+
try {
561+
$this->fake->assertNothingDispatched();
562+
$this->fail();
563+
} catch (ExpectationFailedException $e) {
564+
$this->assertStringContainsString('The following jobs were dispatched unexpectedly:', $e->getMessage());
565+
$this->assertStringContainsString(ChainedJobStub::class, $e->getMessage());
566+
}
563567
}
564568

565569
public function testAssertDispatchedWithIgnoreClass()
@@ -675,12 +679,12 @@ public function testAssertNothingBatched()
675679
}
676680
}
677681

678-
public function testAssertEmptyPasses()
682+
public function testAssertNothingPlacedPasses()
679683
{
680684
$this->fake->assertNothingPlaced();
681685
}
682686

683-
public function testAssertEmptyFailedWhenJobBatched()
687+
public function testAssertNothingPlacedWhenJobBatched()
684688
{
685689
$this->fake->batch([new BusJobStub])->dispatch();
686690

@@ -689,7 +693,7 @@ public function testAssertEmptyFailedWhenJobBatched()
689693
$this->fake->assertNothingPlaced();
690694
}
691695

692-
public function testAssertEmptyFailedWhenJobDispatched()
696+
public function testAssertNothingPlacedWhenJobDispatched()
693697
{
694698
$this->fake->dispatch(new BusJobStub);
695699

@@ -698,7 +702,7 @@ public function testAssertEmptyFailedWhenJobDispatched()
698702
$this->fake->assertNothingPlaced();
699703
}
700704

701-
public function testAssertEmptyFailedWhenJobChained()
705+
public function testAssertNothingPlacedWhenJobChained()
702706
{
703707
$this->fake->chain([new ChainedJobStub])->dispatch();
704708

@@ -707,7 +711,7 @@ public function testAssertEmptyFailedWhenJobChained()
707711
$this->fake->assertNothingPlaced();
708712
}
709713

710-
public function testAssertEmptyFailedWhenJobDispatchedNow()
714+
public function testAssertNothingPlacedWhenJobDispatchedNow()
711715
{
712716
$this->fake->dispatchNow(new BusJobStub);
713717

0 commit comments

Comments
 (0)