Fix compiling queries that use orderByRaw with expressions (#57228)

* Fix compiling queries that use orderByRaw with expressions

This fixes an issue caused by the removal of automatic casting of Expression objects to strings in Laravel 10.

$sql = DB::table('users')
        ->select('id')
        ->orderByRaw(DB::raw('length(name) desc'))
        ->toSql();

fails without this change.

* Update src/Illuminate/Database/Query/Grammars/Grammar.php

* Add tests for compileOrders method in Grammar

Author: LukeTowers

src/Illuminate/Database/Query/Grammars/Grammar.php

@@ -987,7 +987,11 @@ protected function compileOrders(Builder $query, $orders)
      */
     protected function compileOrdersToArray(Builder $query, $orders)
     {
-        return array_map(function ($order) {
+        return array_map(function ($order) use ($query) {
+            if (isset($order['sql']) && $order['sql'] instanceof Expression) {
+                return $order['sql']->getValue($query->getGrammar());
+            }
+
             return $order['sql'] ?? $this->wrap($order['column']).' '.$order['direction'];
         }, $orders);
     }

tests/Database/DatabaseQueryGrammarTest.php

@@ -42,4 +42,40 @@ public function testWhereRawReturnsStringWhenStringPassed()
 
         $this->assertSame('select * from "users"', $rawQuery);
     }
+
+    public function testCompileOrdersAcceptsExpression()
+    {
+        $builder = m::mock(Builder::class);
+        $grammar = new Grammar(m::mock(Connection::class));
+
+        // compileOrders() calls $query->getGrammar() → return our $grammar
+        $builder->shouldReceive('getGrammar')->andReturn($grammar);
+
+        $orders = [
+            ['sql' => new Expression('length("name") desc')], // mimics orderByRaw(DB::raw(...))
+        ];
+
+        $ref = new \ReflectionClass($grammar);
+        $method = $ref->getMethod('compileOrders'); // protected
+        $sql = $method->invoke($grammar, $builder, $orders);
+
+        $this->assertSame('order by length("name") desc', strtolower($sql));
+    }
+
+    public function testCompileOrdersAcceptsExpressionWithPlaceholders()
+    {
+        $builder = m::mock(Builder::class);
+        $grammar = new Grammar(m::mock(Connection::class));
+        $builder->shouldReceive('getGrammar')->andReturn($grammar);
+
+        $orders = [
+            ['sql' => new Expression('field(status, ?, ?) asc')],
+        ];
+
+        $ref = new \ReflectionClass($grammar);
+        $method = $ref->getMethod('compileOrders');
+        $sql = $method->invoke($grammar, $builder, $orders);
+
+        $this->assertSame('order by field(status, ?, ?) asc', strtolower($sql));
+    }
 }