Commit 5c4b5d8
feat(vertexai): add default dimensions parameter to VertexAIEmbeddings (#1242)
## Summary
Add optional `dimensions` constructor argument to `VertexAIEmbeddings`
class. This allows users to set a default output dimensionality that
will be used for all embedding requests unless explicitly overridden.
## Changes
- Add `dimensions` field to `VertexAIEmbeddings` with default value
`None`
- Update `embed()` method to use constructor default when dimensions not
specified in method call
- Explicit dimensions in method calls override the constructor default
- Full backward compatibility maintained - existing code continues to
work unchanged
## Usage Example
```python
# Set default dimensions in constructor
embeddings = VertexAIEmbeddings(model="text-embedding-004", dimensions=128)
# Uses 128 dimensions (from constructor)
embeddings.embed(["hello", "world"])
# Overrides with 256 dimensions
embeddings.embed(["hello", "world"], dimensions=256)
# Backward compatible - no dimensions specified
embeddings = VertexAIEmbeddings(model="text-embedding-004")
embeddings.embed(["hello", "world"]) # Uses model's default
```
## Test Plan
- [x] Added 5 new unit tests covering all scenarios
- [x] Test that constructor dimensions are used when not specified in
embed()
- [x] Test that explicit dimensions override constructor default
- [x] Test backward compatibility when no default dimensions specified
- [x] Test default dimensions work with embed_documents() and
embed_query()
- [x] All 10 unit tests pass
- [x] Code quality checks pass (lint, format, mypy)
---------
Co-authored-by: Mason Daugherty <mason@langchain.dev>1 parent cce3e34 commit 5c4b5d8
File tree
2 files changed
+109
-4
lines changed- libs/vertexai
- langchain_google_vertexai
- tests/unit_tests
2 files changed
+109
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
| |||
130 | 133 | | |
131 | 134 | | |
132 | 135 | | |
133 | | - | |
| 136 | + | |
134 | 137 | | |
135 | | - | |
136 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
137 | 141 | | |
138 | 142 | | |
139 | 143 | | |
| |||
142 | 146 | | |
143 | 147 | | |
144 | 148 | | |
| 149 | + | |
145 | 150 | | |
146 | 151 | | |
147 | 152 | | |
148 | | - | |
| 153 | + | |
149 | 154 | | |
150 | 155 | | |
151 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
0 commit comments