Skip to content

Commit a514805

Browse files
committed
esbuild has bumped Safari support for template literals from v9 to v13
See evanw/esbuild@257a1ad
1 parent ad023fa commit a514805

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

extra/Lamdera/Live.hs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ import Lamdera
1818
import qualified Lamdera.Relative
1919
import qualified Ext.Common
2020

21+
22+
lamderaLiveSrc :: B.Builder
2123
lamderaLiveSrc =
2224
Lamdera.unsafe $
2325
if Ext.Common.isDebug_

extra/dist/live.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/live.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
// This file needs to be minified into dist. `lamdera live` does this in LDEBUG mode, but manually:
1+
// This file needs to be minified into dist for release:
22
// cd extra
33
// esbuild live.js --bundle --minify --target=chrome58,firefox57,safari11,edge16 > dist/live.js
4+
// `lamdera live` does this automatically LDEBUG mode
45

56
import * as Sockette from 'sockette';
67
import * as Cookie from 'js-cookie';

extra/readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ Used by `lamdera live`, this file needs to be packaged with parcel into `/extra/
154154

155155
To package whenever changes are made to this file:
156156

157-
- Run the esbuild instructions are at the top of ./extra/dist/live.js.
157+
- Run the esbuild instructions at the top of ./extra/live.js.
158158
- Modify the `extra/Lamdera/Live.hs` file in some way (`x = 1` works well) to ensure it will get recompiled
159159
- Then re-run the main build with `stack install`.
160160

@@ -170,4 +170,4 @@ The `$(...)` syntax is invoking Template Haskell.
170170

171171
⚠️ Because unchanged files aren't recompiled, you might need to add an `x = 1` to the bottom of the `.hs` file to force a change, and thus the expression to be re-evaluated. If you find you've updated a static file, but the complied binary still has the old one, this is likely the reason why.
172172

173-
In development, using `LDEBUG=1` will cause `~/dev/projects/lamdera-compiler/extra/dist/live.js` to be dynamically included + built on first binary boot (so a kill+reboot+refresh will get the latest local live.js, esbuild it and inject it).
173+
In development, using `LDEBUG=1` will cause `~/dev/projects/lamdera-compiler/extra/dist/live.js` to be dynamically included + rebuilt, helpful when working on it with `lamdera live` to see changes right away, see logic in `Lamdera.Live.lamderaLiveSrc`.

0 commit comments

Comments
 (0)