Scope FFI include fix to Mac only

Author: supermario

Shakefiles/Dependencies.hs

@@ -4,25 +4,24 @@ import Development.Shake
 import Development.Shake.Command
 import Development.Shake.FilePath
 import Development.Shake.Util
+-- import Shakefiles.Platform (platform, Platform(..))
+import Shakefiles.Extra
 
 
 localBinDir :: String
 localBinDir = "bin"
 
---ghc-option required because of https://gitlab.haskell.org/ghc/ghc/-/issues/20592
-ghcOptionFFI = "--ghc-option=-I/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/ffi"
-
 
 cabalInstallExe :: String -> Action ()
 cabalInstallExe package =
-    cmd_ "cabal"
+    cmd_ "cabal" $
+        addGhcOptionFFI
         [ "v2-install"
         , package
         , "--installdir", localBinDir
         -- these are currently needed because Windows doesn't support the default symlink method
         , "--install-method=copy"
         , "--overwrite-policy=always"
-        , ghcOptionFFI
         ]
 
 
@@ -45,7 +44,7 @@ rules = do
             , "cabal.project"
             , "cabal.project.freeze"
             ]
-        cmd_ "cabal" [ "v2-build", "--only-dependencies", ghcOptionFFI ]
+        cmd_ "cabal" $ addGhcOptionFFI [ "v2-build", "--only-dependencies" ]
         writeFile' out ""
 
     "_build/cabal-test-dependencies.ok" %> \out -> do
@@ -54,7 +53,7 @@ rules = do
             , "cabal.project"
             , "cabal.project.freeze"
             ]
-        cmd_ "cabal" [ "v2-build", "--only-dependencies", "--enable-tests", ghcOptionFFI ]
+        cmd_ "cabal" $ addGhcOptionFFI [ "v2-build", "--only-dependencies", "--enable-tests" ]
         writeFile' out ""
 
     shellcheck %> \out -> do

Shakefiles/Extra.hs

@@ -1,7 +1,8 @@
-module Shakefiles.Extra (phonyPrefix, forEach) where
+module Shakefiles.Extra (phonyPrefix, forEach, addGhcOptionFFI) where
 
 import Development.Shake
 import Data.List (stripPrefix)
+import Shakefiles.Platform (platform, Platform(..))
 
 
 phonyPrefix :: String -> (String -> Action ()) -> Rules ()
@@ -15,3 +16,11 @@ phonyPrefix prefix action =
 forEach :: Monad m => [a] -> (a -> m ()) -> m ()
 forEach list f =
     mapM_ f list
+
+
+--ghc-option required because of https://gitlab.haskell.org/ghc/ghc/-/issues/20592
+addGhcOptionFFI :: [String] -> [String]
+addGhcOptionFFI options =
+    case platform of
+        Mac -> ["--ghc-option=-I/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/ffi"] ++ options
+        _ -> options

Shakefiles/Haskell.hs

@@ -11,9 +11,6 @@ import Data.Char (isSpace)
 import Data.List (dropWhileEnd, stripPrefix)
 import Shakefiles.Extra
 
--- --ghc-option required because of https://gitlab.haskell.org/ghc/ghc/-/issues/20592
-ghcOptionFFI = "--ghc-option=-I/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/ffi"
-
 
 cabalProject :: String -> [String] -> [String] -> [String] -> [String] -> [String] -> Rules ()
 cabalProject name sourceFiles sourcePatterns deps testPatterns testDeps =
@@ -38,16 +35,16 @@ cabalProject name sourceFiles sourcePatterns deps testPatterns testDeps =
     do
         "_build/cabal/" </> name </> "build.ok" %> \out -> do
             hash <- needProjectFiles
-            cmd_ "cabal" "v2-build" ghcOptionFFI "-O0"  (cabalName name ++ ":libs") "--enable-tests"
+            cmd_ "cabal" $ addGhcOptionFFI ["v2-build", "-O0",  (cabalName name ++ ":libs"), "--enable-tests" ]
             writeFile' out hash
 
         cabalBinPath name "noopt" %> \out -> do
             _ <- needProjectFiles
-            cmd_ "cabal" "v2-build" ghcOptionFFI "-O0" (cabalName name ++ ":exes") "--enable-tests"
+            cmd_ "cabal" $ addGhcOptionFFI ["v2-build", "-O0", (cabalName name ++ ":exes"), "--enable-tests" ]
 
         cabalBinPath name "opt" %> \out -> do
             _ <- needProjectFiles
-            cmd_ "cabal" "v2-build" ghcOptionFFI "-O2" (cabalName name ++ ":exes")
+            cmd_ "cabal" $ addGhcOptionFFI ["v2-build", "-O2", (cabalName name ++ ":exes") ]
 
         "_build/cabal/" </> name </> "test.ok" %> \out -> do
             need globalConfig
@@ -58,7 +55,7 @@ cabalProject name sourceFiles sourcePatterns deps testPatterns testDeps =
             need sourceFilesFromPatterns
             testFiles <- getDirectoryFiles "" testPatterns
             need testFiles
-            cmd_ "cabal" "v2-test" "-O0" (cabalName name ++ ":tests") "--test-show-details=streaming" ghcOptionFFI
+            cmd_ "cabal" $ addGhcOptionFFI ["v2-test", "-O0", (cabalName name ++ ":tests"), "--test-show-details=streaming" ]
             writeFile' out ""
 
 

build.sh

@@ -6,9 +6,12 @@ PKG_ENV_FILE="_build/shake-package-env-$(ghc --numeric-version)"
 mkdir -p _build
 # install shake if it's not installed
 if ! grep -qs '^package-id \(shake\|shk\)-' "$PKG_ENV_FILE"; then
-  echo "$0: installing shake"
-  # --ghc-option required because of https://gitlab.haskell.org/ghc/ghc/-/issues/20592
-  cabal v2-install --package-env "$PKG_ENV_FILE" --ghc-option="`pkg-config --cflags libffi`" --lib shake
+  if [[ $OSTYPE == darwin* ]]; then
+    # --ghc-option required because of https://gitlab.haskell.org/ghc/ghc/-/issues/20592
+    cabal v2-install --package-env "$PKG_ENV_FILE" --ghc-option="`pkg-config --cflags libffi`" --lib shake
+  else
+    cabal v2-install --package-env "$PKG_ENV_FILE" --lib shake
+  fi
 fi
 
 # compile the build script