Merge pull request #16 from lambdalisue/fix-windows

🐛 Fix several bugs on Windows

Author: lambdalisue

autoload/guise.vim

@@ -11,12 +11,12 @@ function! guise#open(address, argv) abort
         call s:request(chan, 'edit', [fnamemodify(filename, ':p')])
       endfor
     endif
+    call s:close(chan)
     qall!
   catch
     call s:request(chan, 'error', [v:exception, v:throwpoint])
-    cquit!
-  finally
     call s:close(chan)
+    cquit!
   endtry
 endfunction
 
@@ -56,7 +56,7 @@ else
           \ 'mode': 'json',
           \ 'drop': 'auto',
           \ 'noblock': 1,
-          \ 'timeout': 60 * 60 * 24 * 7,
+          \ 'timeout': 60 * 60 * 24 * 7 * 1000,
           \})
     if ch_status(chan) !=# 'open'
       echohl WarningMsg

denops/guise/main.ts

@@ -44,7 +44,21 @@ export async function main(denops: Denops): Promise<void> {
         "-N", // No compatible
         "-n", // No swapfile
         "-X", // Do not try connecting to the X server
-        "-es", // Ex batch mode
+        // Ex mode
+        // On Windows, when `-e` is specified, calls via non-terminal (e.g. job or Deno)
+        // hang for some reason.
+        // However, if you do not use `-e`, you will get the following warnings
+        //
+        //  Vim: Warning: Output is not to a terminal
+        //  Vim: Warning: Input is not from a terminal
+        //
+        // For now, we don't know how to deal with these warnings, so we are treating
+        // them as specifications.
+        ...(denops.meta.platform === "windows" ? [] : ["-e"]),
+        // Silent batch mode
+        // On Windows, if `-s` is specified, for some reason, it immediately terminates
+        // and does not function properly.
+        ...(denops.meta.platform === "windows" ? [] : ["-s"]),
       ];
     } else {
       args = [
@@ -53,7 +67,14 @@ export async function main(denops: Denops): Promise<void> {
         "--headless",
       ];
     }
-    await vars.e.set(denops, "EDITOR", `${config.progpath} ${args.join(" ")}`);
+    const progpath = denops.meta.platform === "windows"
+      ? `"${config.progpath}"`
+      : `'${config.progpath}'`;
+    await vars.e.set(
+      denops,
+      "EDITOR",
+      `${progpath} ${args.join(" ")}`,
+    );
   }
 }