From 90afc8a896da046e8a8697d966e75ce85dd97155 Mon Sep 17 00:00:00 2001 From: Galoretka Date: Mon, 27 Oct 2025 19:48:38 +0200 Subject: [PATCH 1/3] Remove duplicate get_integer_from_var_name tests from memcpy_hint_utils --- .../memcpy_hint_utils.rs | 60 ------------------- 1 file changed, 60 deletions(-) diff --git a/vm/src/hint_processor/builtin_hint_processor/memcpy_hint_utils.rs b/vm/src/hint_processor/builtin_hint_processor/memcpy_hint_utils.rs index ea0d6e799c..af776982af 100644 --- a/vm/src/hint_processor/builtin_hint_processor/memcpy_hint_utils.rs +++ b/vm/src/hint_processor/builtin_hint_processor/memcpy_hint_utils.rs @@ -40,63 +40,3 @@ pub fn memcpy_enter_scope( exec_scopes.enter_scope(HashMap::from([(String::from("n"), len)])); Ok(()) } - -#[cfg(test)] -mod tests { - use super::*; - - use crate::utils::test_utils::*; - use assert_matches::assert_matches; - - use crate::Felt252; - #[cfg(target_arch = "wasm32")] - use wasm_bindgen_test::*; - - #[test] - #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] - fn get_integer_from_var_name_valid() { - let mut vm = vm!(); - // initialize memory segments - vm.segments.add(); - - // initialize fp - vm.run_context.fp = 1; - - let var_name: &str = "variable"; - - //Create ids_data - let ids_data = ids_data![var_name]; - - //Insert ids.prev_locs.exp into memory - vm.segments = segments![((1, 0), 10)]; - - assert_eq!( - get_integer_from_var_name(var_name, &vm, &ids_data, &ApTracking::default()) - .unwrap() - .as_ref(), - &Felt252::from(10) - ); - } - - #[test] - #[cfg_attr(target_arch = "wasm32", wasm_bindgen_test)] - fn get_integer_from_var_name_invalid_expected_integer() { - let mut vm = vm!(); - - // initialize fp - vm.run_context.fp = 1; - - let var_name: &str = "variable"; - - //Create ids_data - let ids_data = ids_data![var_name]; - - //Insert ids.variable into memory as a RelocatableValue - vm.segments = segments![((1, 0), (1, 1))]; - - assert_matches!( - get_integer_from_var_name(var_name, &vm, &ids_data, &ApTracking::default()), - Err(HintError::IdentifierNotInteger(bx)) if bx.as_ref() == var_name - ); - } -} From ef99286b4ebdb8babd9e4da13fc673ab8df0943f Mon Sep 17 00:00:00 2001 From: Galoretka Date: Mon, 27 Oct 2025 19:51:17 +0200 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e3cd79bd60..1cff889cb5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ #### Upcoming Changes +* chore: remove duplicate get_integer_from_var_name tests from memcpy_hint_utils [#2250](https://github.com/lambdaclass/cairo-vm/pull/2250) + * chore: Bump Rust toolchain to 1.89 [#2245](https://github.com/lambdaclass/cairo-vm/pull/2245) * chore: Remove dead SegmentInfo struct from cairo_runner.rs [#2235](https://github.com/lambdaclass/cairo-vm/pull/2235) From 86143e426593213f26b466165b2063b6f96a7220 Mon Sep 17 00:00:00 2001 From: Galoretka Date: Fri, 14 Nov 2025 17:21:41 +0200 Subject: [PATCH 3/3] remove changelog --- CHANGELOG.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5a8cab5c46..bafbc7ba2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,8 +2,6 @@ #### Upcoming Changes -* chore: remove duplicate get_integer_from_var_name tests from memcpy_hint_utils [#2250](https://github.com/lambdaclass/cairo-vm/pull/2250) - * opt(breaking): Avoid cloning constants when compiling hints [#2208](https://github.com/lambdaclass/cairo-vm/pull/2208) * dev(BREAKING): Make blake2s API internal [#2265](https://github.com/lambdaclass/cairo-vm/pull/2265)