make ValidationRules clonable, without API breakage

Author: JulianGCalderon

vm/src/vm/runners/builtin_runner/range_check.rs

@@ -3,7 +3,6 @@ use crate::{
     stdlib::{
         cmp::{max, min},
         prelude::*,
-        rc::Rc,
     },
     types::{builtin_name::BuiltinName, instance_definitions::LowRatio},
 };
@@ -107,7 +106,7 @@ impl<const N_PARTS: u64> RangeCheckBuiltinRunner<N_PARTS> {
     }
 
     pub fn add_validation_rule(&self, memory: &mut Memory) {
-        let rule = ValidationRule(Rc::new(
+        let rule = ValidationRule(Box::new(
             |memory: &Memory, address: Relocatable| -> Result<Vec<Relocatable>, MemoryError> {
                 let num = memory
                     .get_integer(address)

vm/src/vm/runners/builtin_runner/signature.rs

@@ -96,7 +96,7 @@ impl SignatureBuiltinRunner {
     pub fn add_validation_rule(&self, memory: &mut Memory) {
         let cells_per_instance = CELLS_PER_SIGNATURE;
         let signatures = Rc::clone(&self.signatures);
-        let rule: ValidationRule = ValidationRule(Rc::new(
+        let rule: ValidationRule = ValidationRule(Box::new(
             move |memory: &Memory, addr: Relocatable| -> Result<Vec<Relocatable>, MemoryError> {
                 let cell_index = addr.offset % cells_per_instance as usize;
 

vm/src/vm/vm_memory/memory.rs

@@ -12,10 +12,9 @@ use bitvec::prelude as bv;
 use core::cmp::Ordering;
 use num_traits::ToPrimitive;
 
-#[derive(Clone)]
 pub struct ValidationRule(
     #[allow(clippy::type_complexity)]
-    pub  Rc<dyn Fn(&Memory, Relocatable) -> Result<Vec<Relocatable>, MemoryError>>,
+    pub  Box<dyn Fn(&Memory, Relocatable) -> Result<Vec<Relocatable>, MemoryError>>,
 );
 
 /// [`MemoryCell`] represents an optimized storage layout for the VM memory.
@@ -174,7 +173,7 @@ pub struct Memory {
     #[cfg(feature = "extensive_hints")]
     pub(crate) relocation_rules: HashMap<usize, MaybeRelocatable>,
     pub validated_addresses: AddressSet,
-    validation_rules: Vec<Option<ValidationRule>>,
+    validation_rules: Vec<Option<Rc<ValidationRule>>>,
 }
 
 impl Memory {
@@ -501,7 +500,8 @@ impl Memory {
             self.validation_rules
                 .resize_with(segment_index + 1, || None);
         }
-        self.validation_rules.insert(segment_index, Some(rule));
+        self.validation_rules
+            .insert(segment_index, Some(Rc::new(rule)));
     }
 
     fn validate_memory_cell(&mut self, addr: Relocatable) -> Result<(), MemoryError> {