Skip to content

Conversation

@FinleyGe
Copy link
Collaborator

@FinleyGe FinleyGe commented Nov 7, 2025

Note

Ensure migrated folders/apps use new parent folder IDs and replicate resource permissions, skipping updates when parent mapping is missing.

  • Backend (migration):
    • Update projects/app/src/pages/api/admin/initv4141.ts to remap parentId to the corresponding newId of migrated folders.
      • Skip updates when no mapped newParentId exists.
      • For tool-type apps, set parentId to newParentId similarly.
    • Duplicate resource permissions for new folders by inserting RP documents with resourceId set to the new folder IDs.

Written by Cursor Bugbot for commit 94bb6b7. This will update automatically on new commits. Configure here.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Preview mcp_server Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_mcp_server_94bb6b70ad9690b3d798940fc879f4cb0af04043

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Preview sandbox Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_sandbox_94bb6b70ad9690b3d798940fc879f4cb0af04043

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Docs Preview:


🚀 FastGPT Document Preview Ready!

🔗 👀 Click here to visit preview

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Preview fastgpt Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_94bb6b70ad9690b3d798940fc879f4cb0af04043

@c121914yu c121914yu merged commit 99ef1d1 into labring:v4.14.1-dev Nov 9, 2025
6 checks passed
@gru-agent
Copy link
Contributor

gru-agent bot commented Nov 9, 2025

⏳ Processing in progress

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on December 12

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

const newParentId = obj?.parentId ? appMap.get(obj!.parentId)?.newId : null;
if (!newParentId) {
continue;
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Top-Level Folder Permissions Migration Failure

The early continue at line 97 skips resource permission migration for top-level folders (folders without a parent). When obj.parentId is null/undefined, newParentId becomes null, causing the loop to skip before the rpOps.push at line 101, preventing these folders from having their permissions properly migrated to the new toolFolder type.

Fix in Cursor Fix in Web

@FinleyGe FinleyGe deleted the fix/init4141 branch November 10, 2025 02:27
c121914yu added a commit that referenced this pull request Nov 11, 2025
* feat: app split (#5858)

* feat: app split script

* fix: app split

* chore: app split script try-catch

* adjust dashborad page (#5872)

* create page

* create page

* create button

* router name

* bot

* template

* create page

* mobile

* toolfolder

* fix

* fix

* fix build

* split tool select

* img

* doc

* rename enum

* fix page adjust (#5883)

* fix page adjust

* fix ad store

* fix: initv4141 (#5886)

* fix: create app

* doc

* hide api

* doc

* feat: payment pause interactive (#5892)

* fix: copy clbs (#5889)

* fix: copy clbs

* fix: copy clbs

* fix: http protocol handling in baseURL (#5890)

* fix: http protocol handling in baseURL

* ui fix

* auto saved version

* fix

* auto save

* fix: model permission modal (#5895)

* folder

* fix: del app

* navbar

* fix: plugin file selector (#5893)

* fix: plugin file selector

* fix: plugin file selector

* workflow tool inputform

* pick

---------

Co-authored-by: archer <545436317@qq.com>

* fix: workflow tool time

* doc

* fix workorder button (#5896)

* add inform track (#5897)

* remove invalid track

* comment

* feat: marketplace refresh api (#5884)

* marketplace refresh

* fix: helper bot menu button (#5898)

---------

Co-authored-by: Finley Ge <32237950+FinleyGe@users.noreply.github.com>
Co-authored-by: heheer <heheer@sealos.io>
Co-authored-by: 伍闲犬 <whoeverimf5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants