Skip to content

Commit b951de1

Browse files
authored
Merge pull request #1722 from Bastian-Krause/bst/coordinator-finally-returns
remote/coordinator: drop returns from finally clauses
2 parents 7084d16 + 11dc2c4 commit b951de1

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

labgrid/remote/coordinator.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -355,13 +355,11 @@ async def request_task():
355355
finally:
356356
try:
357357
session = self.clients.pop(peer)
358+
running_request_task.cancel()
359+
await running_request_task
360+
logging.debug("client aborted %s, cancelled: %s", session, context.cancelled())
358361
except KeyError:
359362
logging.info("Never received startup from peer %s that disconnected", peer)
360-
return
361-
362-
running_request_task.cancel()
363-
await running_request_task
364-
logging.debug("client aborted %s, cancelled: %s", session, context.cancelled())
365363

366364
def _add_default_place(self, name):
367365
if name in self.places:
@@ -462,15 +460,13 @@ async def request_task():
462460

463461
try:
464462
session = self.exporters.pop(peer)
463+
for groupname, group in session.groups.items():
464+
for resourcename in group.copy():
465+
session.set_resource(groupname, resourcename, None)
466+
467+
logging.debug("exporter aborted %s, cancelled: %s", context.peer(), context.cancelled())
465468
except KeyError:
466469
logging.info("Never received startup from peer %s that disconnected", peer)
467-
return
468-
469-
for groupname, group in session.groups.items():
470-
for resourcename in group.copy():
471-
session.set_resource(groupname, resourcename, None)
472-
473-
logging.debug("exporter aborted %s, cancelled: %s", context.peer(), context.cancelled())
474470

475471
@locked
476472
async def AddPlace(self, request, context):

0 commit comments

Comments
 (0)