remote/client: separate ArgumentParser() definition

This is an idiomatic way of setting up argument parsers and allows the
parser to be re-used for manpage/documentation generation.

Signed-off-by: Jonas Rebmann <jre@pengutronix.de>

Author: jonrebm

labgrid/remote/client.py

@@ -1705,23 +1705,7 @@ def __str__(self):
         return self.value
 
 
-def main():
-    basicConfig(
-        level=logging.WARNING,
-        stream=sys.stderr,
-    )
-
-    StepLogger.start()
-    processwrapper.enable_logging()
-
-    # Support both legacy variables and properly namespaced ones
-    place = os.environ.get("PLACE", None)
-    place = os.environ.get("LG_PLACE", place)
-    state = os.environ.get("STATE", None)
-    state = os.environ.get("LG_STATE", state)
-    initial_state = os.environ.get("LG_INITIAL_STATE", None)
-    token = os.environ.get("LG_TOKEN", None)
-
+def get_parser() -> argparse.ArgumentParser:
     parser = argparse.ArgumentParser()
     parser.add_argument(
         "-x",
@@ -1734,24 +1718,19 @@ def main():
         "-c",
         "--config",
         type=str,
-        default=os.environ.get("LG_ENV"),
         help="env config file (default: value from env variable LG_ENV)",
     )
-    parser.add_argument(
-        "-p", "--place", type=str, default=place, help="place name/alias (default: value from env variable LG_PLACE)"
-    )
+    parser.add_argument("-p", "--place", type=str, help="place name/alias (default: value from env variable LG_PLACE)")
     parser.add_argument(
         "-s",
         "--state",
         type=str,
-        default=state,
         help="strategy state to switch into before command (default: value from env varibale LG_STATE)",
     )
     parser.add_argument(
         "-i",
         "--initial-state",
         type=str,
-        default=initial_state,
         help="strategy state to force into before switching to desired state",
     )
     parser.add_argument(
@@ -2065,11 +2044,11 @@ def main():
     subparser.set_defaults(func=ClientSession.create_reservation)
 
     subparser = subparsers.add_parser("cancel-reservation", help="cancel a reservation")
-    subparser.add_argument("token", type=str, default=token, nargs="?" if token else None)
+    subparser.add_argument("token", type=str, nargs="?")
     subparser.set_defaults(func=ClientSession.cancel_reservation)
 
     subparser = subparsers.add_parser("wait", help="wait for a reservation to be allocated")
-    subparser.add_argument("token", type=str, default=token, nargs="?" if token else None)
+    subparser.add_argument("token", type=str, nargs="?")
     subparser.set_defaults(func=ClientSession.wait_reservation)
 
     subparser = subparsers.add_parser("reservations", help="list current reservations")
@@ -2092,13 +2071,55 @@ def main():
     subparser = subparsers.add_parser("version", help="show version")
     subparser.set_defaults(func=ClientSession.print_version)
 
+    return parser
+
+
+def main():
+    basicConfig(
+        level=logging.WARNING,
+        stream=sys.stderr,
+    )
+
+    StepLogger.start()
+    processwrapper.enable_logging()
+
+    # Support both legacy variables and properly namespaced ones
+    place = os.environ.get("PLACE", None)
+    place = os.environ.get("LG_PLACE", place)
+    state = os.environ.get("STATE", None)
+    state = os.environ.get("LG_STATE", state)
+    initial_state = os.environ.get("LG_INITIAL_STATE", None)
+    token = os.environ.get("LG_TOKEN", None)
+
+    parser = get_parser()
+
     # make any leftover arguments available for some commands
     args, leftover = parser.parse_known_args()
     if args.command not in ["ssh", "rsync", "forward"]:
         args = parser.parse_args()
     else:
         args.leftover = leftover
 
+    # handle dynamic defaults
+    if args.config is None:
+        args.config = os.environ.get("LG_ENV")
+
+    if args.place is None:
+        args.place = place
+
+    if args.state is None:
+        args.state = state
+
+    if args.initial_state is None:
+        args.initial_state = initial_state
+
+    if args.command in ["cancel-reservation", "wait"] and args.token is None:
+        if token:
+            args.token = token
+        else:
+            print("Please provide a token", file=sys.stderr)
+            exit(1)
+
     if args.verbose:
         logging.getLogger().setLevel(logging.INFO)
     if args.verbose > 1: