fix: IN operator can be both a list and a single value (#320)

Author: BramKaashoek

.changeset/plain-bugs-fold.md

@@ -0,0 +1,5 @@
+---
+"@labdigital/commercetools-mock": patch
+---
+
+fix: IN operator can be both a list and a single value

src/lib/predicateParser.test.ts

@@ -151,43 +151,11 @@ describe("Predicate filter", () => {
 		expect(match("numberProperty in (1234)")).toBeTruthy();
 	});
 
-	test("in operator with and clause", async () => {
-		expect(
-			match("numberProperty in (1234) and stringProperty=:val", {
-				val: "foobar",
-			}),
-		).toBeTruthy();
-		expect(
-			match("numberProperty in (1234) and stringProperty=:val", {
-				val: "other",
-			}),
-		).toBeFalsy();
-		expect(
-			match("numberProperty in (1235) and stringProperty=:val", {
-				val: "foobar",
-			}),
-		).toBeFalsy();
-	});
-
-	test("within operator with and clause", async () => {
-		expect(
-			match(
-				"geoLocation within circle(5.121310867198959, 52.09068804569714, 2500) and stringProperty=:val",
-				{ val: "foobar" },
-			),
-		).toBeTruthy();
-		expect(
-			match(
-				"geoLocation within circle(5.121310867198959, 52.09068804569714, 2500) and stringProperty=:val",
-				{ val: "other" },
-			),
-		).toBeFalsy();
-		expect(
-			match(
-				"geoLocation within circle(5.121310867198959, 52.09068804569714, 1000) and stringProperty=:val",
-				{ val: "foobar" },
-			),
-		).toBeFalsy();
+	test("in operator works with with and without parentheses", async () => {
+		expect(match("numberProperty in :val", { val: 1234 })).toBeTruthy();
+		expect(match("numberProperty in :val", { val: 1235 })).toBeFalsy();
+		expect(match("numberProperty in :val", { val: [1234] })).toBeTruthy();
+		expect(match("numberProperty in :val", { val: [1235] })).toBeFalsy();
 	});
 
 	test("arrayProperty contains all (...)", async () => {

src/lib/predicateParser.ts

@@ -381,8 +381,14 @@ const generateMatchFunc = (predicate: string): MatchFunc => {
 			}
 		})
 		.led("IN", 20, ({ left, bp }) => {
+			const firstToken = lexer.peek();
 			const expr = parser.parse({ terminals: [bp - 1] });
-			lexer.expect(")");
+
+			// IN can be a single value or a list of values
+			if (firstToken.match === "(") {
+				lexer.expect(")");
+			}
+
 			return (obj: any, vars: object) => {
 				let symbols = expr;
 				if (!Array.isArray(symbols)) {