Don't use env vars in all config examples

Author: javiereguiluz

doctrine/pdo_session_storage.rst

@@ -24,8 +24,8 @@ To use it, first register a new handler service:
             Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler:
                 public:    false
                 arguments:
-                    - 'mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%'
-                    - { db_username: '%env(MYDATABASE_USERNAME)%', db_password: '%env(MYDATABASE_PASSWORD)%' }
+                    - 'mysql:dbname=mydatabase, host=myhost'
+                    - { db_username: myuser, db_password: mypassword }
 
     .. code-block:: xml
 
@@ -40,10 +40,10 @@ To use it, first register a new handler service:
 
             <services>
                 <service id="Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler" public="false">
-                    <argument>mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%</argument>
+                    <argument>mysql:dbname=mydatabase, host=myhost</argument>
                     <argument type="collection">
-                        <argument key="db_username">%env(MYDATABASE_USERNAME)%</argument>
-                        <argument key="db_password">%env(MYDATABASE_PASSWORD)%</argument>
+                        <argument key="db_username">myuser</argument>
+                        <argument key="db_password">mypassword</argument>
                     </argument>
                 </service>
             </services>
@@ -55,19 +55,18 @@ To use it, first register a new handler service:
         use Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler;
 
         $storageDefinition = $container->register(PdoSessionHandler::class)
-            ->setArguments(array(
-                'mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%',
-                array('db_username' => '%env(MYDATABASE_USERNAME)%', 'db_password' => '%env(MYDATABASE_PASSWORD)'),
-            ))
-        ;
-
-.. note::
+            ->setArguments(
+                array(
+                    'mysql:dbname=mydatabase, host=myhost',
+                    array('db_username' => 'myuser', 'db_password' => 'mypassword'),
+                )
+            );
 
-    Ideally you want to reuse your database information from your environment variables.
-    These variables can be referenced in the service configuration using ``%env(PARAMETER_NAME)%``.
-    Do not forget to wrap these with single or double quotes in yaml.
+.. tip::
 
-    See :doc:`/configuration/external_parameters`.
+    Configure the database credentials as
+    :doc:`parameters defined with environment variables </configuration/external_parameters>`
+    to make your application more secure.
 
 Next, tell Symfony to use your service as the session handler:
 
@@ -121,8 +120,8 @@ a second array argument to ``PdoSessionHandler``:
             Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler:
                 public:    false
                 arguments:
-                    - 'mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%'
-                    - { db_table: '%env(SESSIONS_TABLE)%, db_username: '%env(MYDATABASE_USERNAME)%', db_password: '%env(MYDATABASE_PASSWORD)%' }
+                    - 'mysql:dbname=mydatabase, host=myhost'
+                    - { db_table: 'sessions', db_username: 'myuser', db_password: 'mypassword' }
 
     .. code-block:: xml
 
@@ -135,11 +134,11 @@ a second array argument to ``PdoSessionHandler``:
 
             <services>
                 <service id="Symfony\Component\HttpFoundation\Session\Storage\Handler\PdoSessionHandler" public="false">
-                    <argument>mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%</argument>
+                    <argument>mysql:dbname=mydatabase, host=myhost</argument>
                     <argument type="collection">
-                        <argument key="db_username">%env(MYDATABASE_USERNAME)%</argument>
-                        <argument key="db_password">%env(MYDATABASE_PASSWORD)%</argument>
-                        <argument key="db_table">%env(SESSIONS_TABLE)%</argument>
+                        <argument key="db_table">sessions</argument>
+                        <argument key="db_username">myuser</argument>
+                        <argument key="db_password">mypassword</argument>
                     </argument>
                 </service>
             </services>
@@ -154,16 +153,10 @@ a second array argument to ``PdoSessionHandler``:
 
         $container->register(PdoSessionHandler::class)
             ->setArguments(array(
-                'mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%',
-                array(
-                    'mysql:dbname=%env(MYDATABASE_NAME)%, host=%env(MYDATABASE_HOST)%',
-                    array(
-                        'db_table' => '%env(SESSIONS_TABLE)%',
-                        'db_username' => '%env(MYDATABASE_USERNAME)%',
-                        'db_password' => '%env(MYDATABASE_PASSWORD)',
-                    ),
-                )
-            );
+                'mysql:dbname=mydatabase, host=myhost',
+                array('db_table' => 'sessions', 'db_username' => 'myuser', 'db_password' => 'mypassword')
+            ))
+        ;
 
 These are parameters that you can configure: