firewall: Remove viper interactive check

filewall.UnblockBootpd() accepts now *run.CommandOptions and use it to
check if we can interact with the user. Update callers to pass options.

Author: nirs

cmd/minikube/cmd/start.go

@@ -353,7 +353,7 @@ func provisionWithDriver(cmd *cobra.Command, ds registry.DriverState, existing *
 	klog.Infof("cluster config:\n%+v", cc)
 
 	if firewall.IsBootpdBlocked(cc) {
-		if err := firewall.UnblockBootpd(); err != nil {
+		if err := firewall.UnblockBootpd(options); err != nil {
 			klog.Warningf("failed unblocking bootpd from firewall: %v", err)
 		}
 	}

pkg/drivers/krunkit/krunkit.go

@@ -305,7 +305,7 @@ func (d *Driver) setupIP(mac string) error {
 	if !isBootpdError(err) {
 		return errors.Wrap(err, "IP address never found in dhcp leases file")
 	}
-	if unblockErr := firewall.UnblockBootpd(); unblockErr != nil {
+	if unblockErr := firewall.UnblockBootpd(&d.CommandOptions); unblockErr != nil {
 		klog.Errorf("failed unblocking bootpd from firewall: %v", unblockErr)
 		exit.Error(reason.IfBootpdFirewall, "ip not found", err)
 	}

pkg/drivers/qemu/qemu.go

@@ -541,7 +541,7 @@ func (d *Driver) Start() error {
 		if !isBootpdError(err) {
 			return errors.Wrap(err, "IP address never found in dhcp leases file")
 		}
-		if unblockErr := firewall.UnblockBootpd(); unblockErr != nil {
+		if unblockErr := firewall.UnblockBootpd(&d.CommandOptions); unblockErr != nil {
 			klog.Errorf("failed unblocking bootpd from firewall: %v", unblockErr)
 			exit.Error(reason.IfBootpdFirewall, "ip not found", err)
 		}

pkg/drivers/vfkit/vfkit.go

@@ -380,7 +380,7 @@ func (d *Driver) setupIP(mac string) error {
 	if !isBootpdError(err) {
 		return errors.Wrap(err, "IP address never found in dhcp leases file")
 	}
-	if unblockErr := firewall.UnblockBootpd(); unblockErr != nil {
+	if unblockErr := firewall.UnblockBootpd(&d.CommandOptions); unblockErr != nil {
 		klog.Errorf("failed unblocking bootpd from firewall: %v", unblockErr)
 		exit.Error(reason.IfBootpdFirewall, "ip not found", err)
 	}

pkg/minikube/firewall/firewall.go

@@ -24,11 +24,11 @@ import (
 	"slices"
 	"strings"
 
-	"github.com/spf13/viper"
 	"k8s.io/klog/v2"
 	"k8s.io/minikube/pkg/minikube/config"
 	"k8s.io/minikube/pkg/minikube/driver"
 	"k8s.io/minikube/pkg/minikube/out"
+	"k8s.io/minikube/pkg/minikube/run"
 	"k8s.io/minikube/pkg/minikube/style"
 )
 
@@ -63,7 +63,7 @@ func IsBootpdBlocked(cc config.ClusterConfig) bool {
 }
 
 // UnblockBootpd adds bootpd to the built-in macOS firewall and then unblocks it
-func UnblockBootpd() error {
+func UnblockBootpd(options *run.CommandOptions) error {
 	cmds := []*exec.Cmd{
 		exec.Command("sudo", "/usr/libexec/ApplicationFirewall/socketfilterfw", "--add", "/usr/libexec/bootpd"),
 		exec.Command("sudo", "/usr/libexec/ApplicationFirewall/socketfilterfw", "--unblock", "/usr/libexec/bootpd"),
@@ -82,7 +82,7 @@ func UnblockBootpd() error {
 		klog.Infof("testing: %s", test.Args)
 		if err := test.Run(); err != nil {
 			klog.Infof("%v may require a password: %v", c.Args, err)
-			if !viper.GetBool("interactive") {
+			if !options.NonInteractive {
 				klog.Warningf("%s requires a password, and --interactive=false", c.Args)
 				c.Args = slices.Insert(c.Args, 1, "-n")
 			}