Skip to content

Commit 9db91ae

Browse files
committed
Address review comments
1 parent cc55e76 commit 9db91ae

File tree

1 file changed

+4
-3
lines changed
  • keps/sig-node/3953-node-resource-hot-plug

1 file changed

+4
-3
lines changed

keps/sig-node/3953-node-resource-hot-plug/README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,11 @@ Hotplug: Dynamically add compute resources (CPU, Memory, Swap Capacity and HugeP
8888

8989
Hotunplug: Dynamically remove compute resources (CPU, Memory, Swap Capacity and HugePages) to the node, either via software (make resources go offline) or via hardware (physical removal while the system is running)
9090

91+
Node Compute Resource: CPU, Memory, Swap Capacity and HugePages
9192

9293
## Summary
9394

94-
The proposal seeks to facilitate hot plugging of node compute resources(CPU, Memory, Swap Capacity and HugePages), thereby streamlining cluster resource capacity updates through node compute resource resizing rather than introducing new nodes to the cluster.
95+
The proposal seeks to facilitate hot plugging of node compute resources, thereby streamlining cluster resource capacity updates through node compute resource resizing rather than introducing new nodes to the cluster.
9596
The revised node configurations will be automatically propagated at both the node and cluster levels.
9697

9798
Furthermore, this proposal intends to enhance the initialization and reinitialization processes of resource managers, including the CPU manager and memory manager, in response to alterations in a node's CPU and memory configurations and
@@ -135,7 +136,7 @@ Implementing this KEP will empower nodes to recognize and adapt to changes in th
135136
### Goals
136137

137138
* Achieve seamless node capacity expansion through hot plugging resources.
138-
* Enable the re-initialization of resource managers (CPU manager, memory manager) and kube runtime manager to accommodate alterations in the node's resource allocation.
139+
* Enable the re-initialization of resource managers (CPU manager, memory manager) and kube runtime manager without reset to accommodate alterations in the node's resource allocation.
139140
* Recalculating and updating the OOMScoreAdj and swap memory limit for existing pods.
140141

141142
### Non-Goals
@@ -913,7 +914,7 @@ VMs of cluster should support hot plug of compute resources for e2e tests.
913914
or if it has to be terminated due to resource crunch.
914915
* Recalculate OOM adjust score and Swap limits:
915916
* Since the total capacity of the node has changed, values associated with the nodes memory capacity must be recomputed.
916-
* Handling unplug of reserved and exclusively allocated cpus CPUs.
917+
* Handling unplug of reserved and exclusively allocated CPUs.
917918
918919
* Fetching machine info via CRI
919920
* At present, the machine data is retrieved from cAdvisor's cache through periodic checks. There is ongoing development to utilize CRI APIs for this purpose.

0 commit comments

Comments
 (0)