You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: keps/sig-api-machinery/3157-watch-list/README.md
+11-2Lines changed: 11 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -760,13 +760,12 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
760
760
761
761
#### Beta2
762
762
- The feature is enabled for kubelet.
763
-
- Add watchlist support to the fake client so that starting an informer with a fake client works correctly.
764
763
- Extend the existing performance tests with a case that adds a large number of small objects.
765
764
The current perf test adds a small number of large objects.
766
765
The new variant will help catch potential regressions such as https://github.com/kubernetes/kubernetes/issues/129467
767
766
768
767
#### Beta3
769
-
With new concerns brought in 1.33 release timeline, we reviset the approach for the feature.
768
+
With new concerns brought in 1.33 release timeline, we revised the approach for the feature.
770
769
The discussion happened in [this document] and resulted in the following update for the criteria:
771
770
772
771
- Revert the client-go changes that use watchList to implement List.
@@ -783,6 +782,16 @@ The discussion happened in [this document] and resulted in the following update
783
782
(This will also allow us to [remove](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/client-go/tools/cache/reflector.go#L110) the `reflector.UseWatchList` field).
784
783
- Enable the feature by-default for kube-controller-manager.
785
784
785
+
#### Beta4
786
+
- Disable watchlist support in the fake client so that informers do not use watchlists.
787
+
This ensures that unit tests relying on non-standard fake client behavior will continue to work.
788
+
- Currently, the `ListWatcher` used by the `WatchCache` does not pass the RV from the reflectors.
789
+
As a result the consistency detector used by the reflectors fails for the `WatchCache`.
790
+
This issue needs to be resolved.
791
+
- Enable the `WatchListClient` feature gate by default.
792
+
The FG is defined in client-go.
793
+
Enabling it will turn on the feature for all clients.
0 commit comments