Skip to content

Commit 8f3e0c5

Browse files
committed
Update KEP 3157 (watch-list) for milestone 1.35
1 parent 787f515 commit 8f3e0c5

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

keps/sig-api-machinery/3157-watch-list/README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -760,13 +760,12 @@ We expect no non-infra related flakes in the last month as a GA graduation crite
760760

761761
#### Beta2
762762
- The feature is enabled for kubelet.
763-
- Add watchlist support to the fake client so that starting an informer with a fake client works correctly.
764763
- Extend the existing performance tests with a case that adds a large number of small objects.
765764
The current perf test adds a small number of large objects.
766765
The new variant will help catch potential regressions such as https://github.com/kubernetes/kubernetes/issues/129467
767766

768767
#### Beta3
769-
With new concerns brought in 1.33 release timeline, we reviset the approach for the feature.
768+
With new concerns brought in 1.33 release timeline, we revised the approach for the feature.
770769
The discussion happened in [this document] and resulted in the following update for the criteria:
771770

772771
- Revert the client-go changes that use watchList to implement List.
@@ -783,6 +782,16 @@ The discussion happened in [this document] and resulted in the following update
783782
(This will also allow us to [remove](https://github.com/kubernetes/kubernetes/blob/a07b1aaa5b39b351ec8586de800baa5715304a3f/staging/src/k8s.io/client-go/tools/cache/reflector.go#L110) the `reflector.UseWatchList` field).
784783
- Enable the feature by-default for kube-controller-manager.
785784

785+
#### Beta4
786+
- Disable watchlist support in the fake client so that informers do not use watchlists.
787+
This ensures that unit tests relying on non-standard fake client behavior will continue to work.
788+
- Currently, the `ListWatcher` used by the `WatchCache` does not pass the RV from the reflectors.
789+
As a result the consistency detector used by the reflectors fails for the `WatchCache`.
790+
This issue needs to be resolved.
791+
- Enable the `WatchListClient` feature gate by default.
792+
The FG is defined in client-go.
793+
Enabling it will turn on the feature for all clients.
794+
786795
[this document]: https://docs.google.com/document/d/1x30DjXSSF5krpyoTCwManJg6vphpnGI37xfCRaiHAbs
787796

788797
#### GA

keps/sig-api-machinery/3157-watch-list/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ stage: beta
2020
# The most recent milestone for which work toward delivery of this KEP has been
2121
# done. This can be the current (upcoming) milestone, if it is being actively
2222
# worked on.
23-
latest-milestone: "v1.34"
23+
latest-milestone: "v1.35"
2424

2525
# The milestone at which this feature was, or is targeted to be, at each stage.
2626
milestone:

0 commit comments

Comments
 (0)