Skip to content

Commit 5f47fb3

Browse files
committed
update KEP-4381 with pciBusID standard device attribute definition
Signed-off-by: Varun Ramachandra Sekar <vsekar@nvidia.com>
1 parent 363d884 commit 5f47fb3

File tree

1 file changed

+14
-4
lines changed
  • keps/sig-node/4381-dra-structured-parameters

1 file changed

+14
-4
lines changed

keps/sig-node/4381-dra-structured-parameters/README.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -492,12 +492,15 @@ Compared to labels, attributes have values of exactly one type. Quantities are d
492492
in the separate `capacity` map. As described later on, both sets can be used in CEL expressions to select a
493493
specific resource for allocation on a node.
494494

495-
We are reserving the `kubernetes.io/` domain (and subdomains) prefix for
495+
We propose reserving the `kubernetes.io/` domain (and subdomains) prefix for
496496
attributes and capacities for standardization by the Kubernetes project. This
497497
reservation allows us to define common attributes that can describe hardware
498-
characteristics across resources from different vendors. Currently, we are
499-
defining one such standard attribute: `resource.kubernetes.io/pcieRoot`. Details
500-
on its meaning and how it should be exposed by DRA drivers are available in the
498+
characteristics across resources from different vendors. This KEP proposes that we maintain
499+
a number of such standard attributes:
500+
1. `resource.kubernetes.io/pcieRoot`
501+
2. `resource.kubernetes.io/pciBusID`
502+
503+
Details on their meaning and how they should be exposed by DRA drivers are available in the
501504
[API design section under ResourceSlice's](#resourceslice) QualifiedName
502505
definition.
503506

@@ -1127,6 +1130,13 @@ const ResourceSliceMaxAttributesAndCapacitiesPerDevice = 32
11271130
// entry in sysfs (e.g., `/sys/devices/pci0000:00/0000:00:01.0/0000:01:00.0`),
11281131
// where the `pci<domain>:<bus>` segment at the beginning of the real path
11291132
// identifies the Root Complex (e.g., `pci0000:00`).
1133+
// 2. `resource.kubernetes.io/pciBusID`: A string value in the format
1134+
// `<socket>:<bus>:<domain>.<function>`, referring to a PCI (Perpheral Component
1135+
// Interconnect) Bus Address. This attribute can be used to identify PCI devices.
1136+
// DRA drivers MAY determine this value by inspecting the device's entry in sysfs
1137+
// (e.g., `/sys/bus/pci/devices/0000:00:01.0`) where the
1138+
// `<socket>:<bus>:<domain>.<function>` segment at the end identifies the PCI
1139+
// Bus Address (e.g., `0000:00:01.0`)
11301140
//
11311141
// The maximum length for the DNS subdomain is 63 characters (same as
11321142
// for driver names) and the maximum length of the C identifier

0 commit comments

Comments
 (0)