Skip to content

Commit 584bae2

Browse files
authored
Merge pull request #5577 from pacoxu/v1-maintainance-mode
update flag name fail-cgroupv1 for kep 4569
2 parents c83ba56 + 232369a commit 584bae2

File tree

1 file changed

+3
-3
lines changed
  • keps/sig-node/4569-cgroup-v1-maintenance-mode

1 file changed

+3
-3
lines changed

keps/sig-node/4569-cgroup-v1-maintenance-mode/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ eventRecorder.Event(pod, v1.EventTypeWarning, "CgroupV1", fmt.Sprint("cgroup v1
151151
```
152152
### Introduce a kubelet flag to disable cgroup v1 support
153153

154-
A new boolean kubelet flag, `--disable-cgroupv1-support`, will be introduced. By default, this flag will be set to `false` to ensure users can continue to use cgroup v1 without any issues. The primary objective of introducing this flag is to set it to `true` in CI, ensuring that all blocking and new CI jobs use only cgroup v2 by default (unless the job explicitly wants to run on cgroup v1).
154+
A new boolean kubelet flag, `--fail-cgroupv1`, will be introduced. By default, this flag will be set to `false` to ensure users can continue to use cgroup v1 without any issues. The primary objective of introducing this flag is to set it to `true` in CI, ensuring that all blocking and new CI jobs use only cgroup v2 by default (unless the job explicitly wants to run on cgroup v1).
155155

156156

157157
### Code modifications for default cgroup assumptions
@@ -268,11 +268,11 @@ This feature won't follow the normal cycle of alpha->beta->GA, and will instead
268268
#### GA
269269
- Kubelet detects the host using cgroup v1, it will not only log a warning message but also generate an event to highlight the cgroup v1 moving to maintenance mode.
270270
- Introduce a new metric, `kubelet_cgroup_version`, to provide insights into the cgroup version utilized by the hosts.
271-
- Introduce a boolean kubelet flag `--disable-cgroupv1-support` and set it to `false` by default.
271+
- Introduce a boolean kubelet flag `--fail-cgroupv1` and set it to `false` by default.
272272
- Blog post on advantages of using cgroup v2 with kubernetes.
273273
- Code modifications for to assume cgroup v2 by default. Check [this]( #code-modifications-for-default-cgroup-assumptions) section for details.
274274
- Ensure all features coverage by running all tests on cgroup v2 (while some may still run on cgroup v1 to test back compatibility)
275-
- Make cgroup v2 host mandatory for new e2e and node e2e jobs. Set `--disable-cgroupv1-support` to `true` for those jobs.
275+
- Make cgroup v2 host mandatory for new e2e and node e2e jobs. Set `--fail-cgroupv1` to `true` for those jobs.
276276
- Fix all pending known bugs in cgroup v2 support in kubernetes.
277277
- Separation of cgroup v1 and cgroup v2 Code Paths. Check [this](#separation-of-cgroup-v1-and-cgroup-v2-code-paths) section for details.
278278

0 commit comments

Comments
 (0)