Skip to content

fix(capacitybuffer): correct spelling mistakes in function names and messages #8850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
moko-poi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(capacitybuffer): correct spelling mistakes in function names and messages #8850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cluster-autoscaler/capacitybuffer/common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ func SetBufferAsReadyForProvisioning(buffer *v1.CapacityBuffer, PodTemplateRef *
Type: ReadyForProvisioningCondition,
Status: ConditionTrue,
Message: "ready",
Reason: "atrtibutesSetSuccessfully",
Reason: "attributesSetSuccessfully",
LastTransitionTime: metav1.Time{Time: time.Now()},
}
buffer.Status.Conditions = []metav1.Condition{readyCondition}
}

// SetBufferAsNotReadyForProvisioning updates the passed buffer object with the rest of the attributes and sets its condition to not ready with the passed error
func SetBufferAsNotReadyForProvisioning(buffer *v1.CapacityBuffer, PodTemplateRef *v1.LocalObjectRef, podTemplateGeneration *int64, replicas *int32, provStrategy *string, err error) {
errorMessage := "Buffer not ready for provisioing"
errorMessage := "Buffer not ready for provisioning"
if err != nil {
errorMessage = err.Error()
}
Expand All @@ -80,8 +80,8 @@ func mapEmptyProvStrategyToDefault(ps *string) *string {
return ps
}

// UpdateBufferStatusToFailedProvisioing updates the status of the passed buffer and set Provisioning to false with the passes reason and message
func UpdateBufferStatusToFailedProvisioing(buffer *v1.CapacityBuffer, reason, errorMessage string) {
// UpdateBufferStatusToFailedProvisioning updates the status of the passed buffer and set Provisioning to false with the passed reason and message
func UpdateBufferStatusToFailedProvisioning(buffer *v1.CapacityBuffer, reason, errorMessage string) {
buffer.Status.Conditions = []metav1.Condition{{
Type: ProvisioningCondition,
Status: ConditionFalse,
Expand All @@ -91,8 +91,8 @@ func UpdateBufferStatusToFailedProvisioing(buffer *v1.CapacityBuffer, reason, er
}}
}

// UpdateBufferStatusToSuccessfullyProvisioing updates the status of the passed buffer and set Provisioning to true with the passes reason
func UpdateBufferStatusToSuccessfullyProvisioing(buffer *v1.CapacityBuffer, reason string) {
// UpdateBufferStatusToSuccessfullyProvisioning updates the status of the passed buffer and set Provisioning to true with the passed reason
func UpdateBufferStatusToSuccessfullyProvisioning(buffer *v1.CapacityBuffer, reason string) {
buffer.Status.Conditions = []metav1.Condition{{
Type: ProvisioningCondition,
Status: ConditionTrue,
Expand Down
6 changes: 3 additions & 3 deletions cluster-autoscaler/processors/capacitybuffer/pod_list_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,17 +134,17 @@ func (p *CapacityBufferPodListProcessor) provision(buffer *v1alpha1.CapacityBuff
replicas := buffer.Status.Replicas
podTemplate, err := p.client.GetPodTemplate(buffer.Namespace, podTemplateName)
if err != nil {
common.UpdateBufferStatusToFailedProvisioing(buffer, "FailedToGetPodTemplate", fmt.Sprintf("failed to get pod template with error: %v", err.Error()))
common.UpdateBufferStatusToFailedProvisioning(buffer, "FailedToGetPodTemplate", fmt.Sprintf("failed to get pod template with error: %v", err.Error()))
p.updateBufferStatus(buffer)
return []*apiv1.Pod{}
}
fakePods, err := makeFakePods(buffer, &podTemplate.Template, int(*replicas))
if err != nil {
common.UpdateBufferStatusToFailedProvisioing(buffer, "FailedToMakeFakePods", fmt.Sprintf("failed to create fake pods with error: %v", err.Error()))
common.UpdateBufferStatusToFailedProvisioning(buffer, "FailedToMakeFakePods", fmt.Sprintf("failed to create fake pods with error: %v", err.Error()))
p.updateBufferStatus(buffer)
return []*apiv1.Pod{}
}
common.UpdateBufferStatusToSuccessfullyProvisioing(buffer, "FakePodsInjected")
common.UpdateBufferStatusToSuccessfullyProvisioning(buffer, "FakePodsInjected")
p.updateBufferStatus(buffer)
return fakePods
}
Expand Down
Loading