Allow VPA e2e tests to reference a custom namespace

[maxcao13]

Which component are you using?:
/area vertical-pod-autoscaler

Is your feature request designed to solve a problem? If so describe the problem this feature should solve.:
If deploying the VPA in a namespace that is not kube-system there some e2e tests fail because they expect that hardcoded namespace. This is fundamentally different from how the VPA is setup where it is possible to use custom namespaces for certain features.

For example, for the admission-controller status lease, the VPA currently defaults to AdmissionControllerStatusNamespace = metav1.NamespaceSystem, but if the VPA container itself detects it is deployed in a differente namespace, it will default to that instead:

autoscaler/vertical-pod-autoscaler/pkg/updater/main.go

Lines 200 to 203 in 1332499

	admissionControllerStatusNamespace := status.AdmissionControllerStatusNamespace
	if namespace != "" {
	admissionControllerStatusNamespace = namespace
	}

But the test just uses the kube-system namespace by default:

autoscaler/vertical-pod-autoscaler/e2e/v1/updater.go

Lines 45 to 53 in 2eb783b

	ginkgo.By("Setting up the Admission Controller status")
	stopCh := make(chan struct{})
	statusUpdater := status.NewUpdater(
	f.ClientSet,
	status.AdmissionControllerStatusName,
	status.AdmissionControllerStatusNamespace,
	statusUpdateInterval,
	"e2e test",
	)

Another example, is this e2e helper function here, which assumes the recommender is in the kube-system namespace:

autoscaler/vertical-pod-autoscaler/e2e/v1/recommender.go

Line 416 in 2eb783b

namespace := "kube-system"

Describe the solution you'd like.:
Perhaps a custom go test flag or environment variable can be used to specify a namespace other than kube-system as overrides.

Smaller ask, but I also would like the common namespace reference in the e2e tests to be centralized. Right now there exists VpaNamespace variable in e2e/vi/common, RecommenderNamespace in e2e/utils/common.go which also references the kube-system as well. And other future and existing namespaces referencing the VPA namespace should be pointed to by this centrailized variable as well.

Describe any alternative solutions you've considered.:
You can also tell me off, if you believe this is overengineering :-)

This is simple to fix in our fork, but since the namespace overrides work in the actual code, I would think it would make sense for the e2es to cover this as well.

[adrianmoisey]

You can also tell me off, if you believe this is overengineering :-)

Nah, this seems reasonable to me!

/trage accepted

[adrianmoisey]

/trage accept

[adrianmoisey]

sigh

/triage accepted

[omerap12]

Yeah, that makes sense and should be straightforward to implement.
I believe @adrianmoisey did something similar before (using a variable when building the Go binary so it propagates to another variable) in this PR. Following a similar approach here could work well.
/good-first-issue

[k8s-ci-robot]

@omerap12:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Yeah, that makes sense and should be straightforward to implement.
I believe @adrianmoisey did something similar before (using a variable when building the Go binary so it propagates to another variable) in this PR. Following a similar approach here could work well.
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AryanBagade]

Hey @omerap12 @adrianmoisey
myself Aryan im an active contributor to multiple projects (facebook/pyrefly) (nvidia/dynamo) and now really wants to get my hands into it starting this issue
could you please assign me this!!!

Thanks

[adrianmoisey]

You're welcome to work on this.
You can assign yourself by making a comment "/assign"

[AryanBagade]

/assign

[AryanBagade]

Thanks!!