Skip to content

Commit a93ef01

Browse files
authored
Merge pull request #116 from MrFreezeex/add-version-crd
crd: add label with CRD version
2 parents 44eb577 + 542057f commit a93ef01

File tree

6 files changed

+57
-0
lines changed

6 files changed

+57
-0
lines changed

config/crd-base/multicluster.x-k8s.io_serviceexports.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ apiVersion: apiextensions.k8s.io/v1
1515
kind: CustomResourceDefinition
1616
metadata:
1717
name: serviceexports.multicluster.x-k8s.io
18+
labels:
19+
multicluster.x-k8s.io/release-version: "v0.3.0"
20+
# The revision is updated on each CRD change and reset back to 0 on every new version.
21+
# It can be used together with the version label when installing those CRDs
22+
# and prevent any downgrades.
23+
multicluster.x-k8s.io/crd-schema-revision: "0"
1824
spec:
1925
group: multicluster.x-k8s.io
2026
scope: Namespaced

config/crd-base/multicluster.x-k8s.io_serviceimports.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ apiVersion: apiextensions.k8s.io/v1
1515
kind: CustomResourceDefinition
1616
metadata:
1717
name: serviceimports.multicluster.x-k8s.io
18+
labels:
19+
multicluster.x-k8s.io/release-version: "v0.3.0"
20+
# The revision is updated on each CRD change and reset back to 0 on every new version.
21+
# It can be used together with the version label when installing those CRDs
22+
# and prevent any downgrades.
23+
multicluster.x-k8s.io/crd-schema-revision: "0"
1824
spec:
1925
group: multicluster.x-k8s.io
2026
scope: Namespaced

config/crd/embed.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,10 @@ var (
2626
//go:embed multicluster.x-k8s.io_serviceimports.yaml
2727
ServiceImportCRD []byte
2828
)
29+
30+
const (
31+
// ReleaseVersionLabel is the label which indicate the release version
32+
ReleaseVersionLabel = "multicluster.x-k8s.io/release-version"
33+
// CustomResourceDefinitionSchemaRevisionLabel is the label which holds the CRD schema revision
34+
CustomResourceDefinitionSchemaRevisionLabel = "multicluster.x-k8s.io/crd-schema-revision"
35+
)

config/crd/multicluster.x-k8s.io_serviceexports.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ apiVersion: apiextensions.k8s.io/v1
1515
kind: CustomResourceDefinition
1616
metadata:
1717
name: serviceexports.multicluster.x-k8s.io
18+
labels:
19+
multicluster.x-k8s.io/release-version: "v0.3.0"
20+
# The revision is updated on each CRD change and reset back to 0 on every new version.
21+
# It can be used together with the version label when installing those CRDs
22+
# and prevent any downgrades.
23+
multicluster.x-k8s.io/crd-schema-revision: "0"
1824
spec:
1925
group: multicluster.x-k8s.io
2026
scope: Namespaced

config/crd/multicluster.x-k8s.io_serviceimports.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ apiVersion: apiextensions.k8s.io/v1
1515
kind: CustomResourceDefinition
1616
metadata:
1717
name: serviceimports.multicluster.x-k8s.io
18+
labels:
19+
multicluster.x-k8s.io/release-version: "v0.3.0"
20+
# The revision is updated on each CRD change and reset back to 0 on every new version.
21+
# It can be used together with the version label when installing those CRDs
22+
# and prevent any downgrades.
23+
multicluster.x-k8s.io/crd-schema-revision: "0"
1824
spec:
1925
group: multicluster.x-k8s.io
2026
scope: Namespaced

hack/verify-crd-bump-revision.sh

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
#!/bin/bash
2+
3+
# Copyright 2025 The Kubernetes Authors.
4+
#
5+
# Licensed under the Apache License, Version 2.0 (the "License");
6+
# you may not use this file except in compliance with the License.
7+
# You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
17+
# Check against master if PULL_BASE_SHA is not defined by prow
18+
BASE_REF="${PULL_BASE_SHA:-master}"
19+
20+
crd_changed="$(git diff --name-only "${BASE_REF}" | grep -c "^config/crd/.*\.yaml$")"
21+
version_label_changed="$(git diff -U0 "${BASE_REF}" -- "config/crd-base/" | grep -c "multicluster.x-k8s.io/crd-schema-revision")"
22+
23+
if [ "${crd_changed}" -gt 0 ] && [ "${version_label_changed}" -ne 2 ]; then
24+
echo "❌ CRDs were modified, but the CRD revision labels were not changed in 'config/crd-base/'. Please bump the CRDs revision."
25+
exit 1
26+
fi

0 commit comments

Comments
 (0)