refactor(markers): remove Kubebuilder prefix from SSA topology marker constants

Signed-off-by: nayuta-ai <nayuta723@gmail.com>

Author: nayuta723

pkg/analysis/markerscope/config.go

@@ -351,28 +351,28 @@ func addGeneralMarkers(rules map[string]MarkerScopeRule) {
 func addSSATopologyMarkers(rules map[string]MarkerScopeRule) {
 	ssaMarkers := map[string]MarkerScopeRule{
 		// Server-Side Apply topology markers
-		markers.KubebuilderListTypeMarker: {
+		markers.ListTypeMarker: {
 			Scope:               AnyScope,
 			NamedTypeConstraint: NamedTypeConstraintRequireTypeDefinition,
 			TypeConstraint: &TypeConstraint{
 				AllowedSchemaTypes: []SchemaType{SchemaTypeArray},
 			},
 		},
-		markers.KubebuilderListMapKeyMarker: {
+		markers.ListMapKeyMarker: {
 			Scope:               AnyScope,
 			NamedTypeConstraint: NamedTypeConstraintRequireTypeDefinition,
 			TypeConstraint: &TypeConstraint{
 				AllowedSchemaTypes: []SchemaType{SchemaTypeArray},
 			},
 		},
-		markers.KubebuilderMapTypeMarker: {
+		markers.MapTypeMarker: {
 			Scope:               AnyScope,
 			NamedTypeConstraint: NamedTypeConstraintRequireTypeDefinition,
 			TypeConstraint: &TypeConstraint{
 				AllowedSchemaTypes: []SchemaType{SchemaTypeObject},
 			},
 		},
-		markers.KubebuilderStructTypeMarker: {
+		markers.StructTypeMarker: {
 			Scope: AnyScope,
 			TypeConstraint: &TypeConstraint{
 				AllowedSchemaTypes: []SchemaType{SchemaTypeObject},

pkg/analysis/ssatags/analyzer.go

@@ -85,7 +85,7 @@ func (a *analyzer) checkField(pass *analysis.Pass, field *ast.Field, markersAcce
 
 	// If the field is a byte array, we cannot use listType markers with it.
 	if utils.IsByteArray(pass, field) {
-		listTypeMarkers := fieldMarkers.Get(kubebuildermarkers.KubebuilderListTypeMarker)
+		listTypeMarkers := fieldMarkers.Get(kubebuildermarkers.ListTypeMarker)
 		for _, marker := range listTypeMarkers {
 			pass.Report(analysis.Diagnostic{
 				Pos:     field.Pos(),
@@ -109,7 +109,7 @@ func (a *analyzer) checkField(pass *analysis.Pass, field *ast.Field, markersAcce
 	}
 
 	fieldName := utils.FieldName(field)
-	listTypeMarkers := fieldMarkers.Get(kubebuildermarkers.KubebuilderListTypeMarker)
+	listTypeMarkers := fieldMarkers.Get(kubebuildermarkers.ListTypeMarker)
 
 	if len(listTypeMarkers) == 0 {
 		pass.Report(analysis.Diagnostic{
@@ -149,7 +149,7 @@ func (a *analyzer) checkListTypeMarker(pass *analysis.Pass, listType string, fie
 }
 
 func (a *analyzer) checkListTypeMap(pass *analysis.Pass, fieldMarkers markers.MarkerSet, field *ast.Field) {
-	listMapKeyMarkers := fieldMarkers.Get(kubebuildermarkers.KubebuilderListMapKeyMarker)
+	listMapKeyMarkers := fieldMarkers.Get(kubebuildermarkers.ListMapKeyMarker)
 	fieldName := utils.FieldName(field)
 
 	isObjectList := utils.IsObjectList(pass, field)

pkg/markers/markers.go

@@ -150,17 +150,17 @@ const (
 	// KubebuilderItemsXValidationMarker is the marker used to specify CEL validation rules for entries to a nested array type or field in kubebuilder.
 	KubebuilderItemsXValidationMarker = "kubebuilder:validation:items:XValidation"
 
-	// KubebuilderListTypeMarker is the marker used to specify the type of list for server-side apply operations.
-	KubebuilderListTypeMarker = "listType"
+	// ListTypeMarker is the marker used to specify the type of list for server-side apply operations.
+	ListTypeMarker = "listType"
 
-	// KubebuilderListMapKeyMarker is the marker used to specify the key field for map-type lists.
-	KubebuilderListMapKeyMarker = "listMapKey"
+	// ListMapKeyMarker is the marker used to specify the key field for map-type lists.
+	ListMapKeyMarker = "listMapKey"
 
-	// KubebuilderMapTypeMarker is the marker used to specify the atomicity level of a map.
-	KubebuilderMapTypeMarker = "mapType"
+	// MapTypeMarker is the marker used to specify the atomicity level of a map.
+	MapTypeMarker = "mapType"
 
-	// KubebuilderStructTypeMarker is the marker used to specify the atomicity level of a struct.
-	KubebuilderStructTypeMarker = "structType"
+	// StructTypeMarker is the marker used to specify the atomicity level of a struct.
+	StructTypeMarker = "structType"
 
 	// KubebuilderSchemaLessMarker is the marker that indicates that a struct is schemaless.
 	KubebuilderSchemaLessMarker = "kubebuilder:validation:Schemaless"