Skip to content

Commit 5ed3db3

Browse files
committed
feedback in progress
1 parent a133245 commit 5ed3db3

File tree

2 files changed

+14
-9
lines changed

2 files changed

+14
-9
lines changed

pkg/analysis/markertypos/testdata/src/a/a.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -96,33 +96,33 @@ type ExampleTypo2 string
9696

9797
// Missing space after // prefix
9898

99-
//+kubebuilder:validation:MaxLength:=256 // want "marker should have space after '//' comment prefix"
99+
// +kubebuilder:validation:MaxLength:=256 // want "marker should have space after '//' comment prefix"
100100
type MissingSpaceKubebuilder string
101101

102-
//+required // want "marker should have space after '//' comment prefix"
102+
// +required // want "marker should have space after '//' comment prefix"
103103
type MissingSpaceNonKubebuilder string
104104

105-
//+optional // want "marker should have space after '//' comment prefix"
105+
// +optional // want "marker should have space after '//' comment prefix"
106106
type MissingSpaceOptional string
107107

108-
//+kubebuilder:object:root:=true // want "marker should have space after '//' comment prefix"
108+
// +kubebuilder:object:root:=true // want "marker should have space after '//' comment prefix"
109109
type MissingSpaceKubebuilderObject string
110110

111-
//+default:value="test" // want "marker should have space after '//' comment prefix"
111+
// +default:value="test" // want "marker should have space after '//' comment prefix"
112112
type MissingSpaceDefault string
113113

114114
// Complex cases with multiple issues
115115

116116
// + kubebuidler:validaton:MaxLength=256 // want "marker should not have space after '\\+' symbol" "possible typo: 'kubebuidler' should be 'kubebuilder'" "possible typo: 'validaton' should be 'validation'"
117117
type MultipleIssues string
118118

119-
//+kubebuidler:validaton:MaxLength=256 // want "marker should have space after '//' comment prefix" "possible typo: 'kubebuidler' should be 'kubebuilder'" "possible typo: 'validaton' should be 'validation'"
119+
// +kubebuidler:validaton:MaxLength=256 // want "marker should have space after '//' comment prefix" "possible typo: 'kubebuidler' should be 'kubebuilder'" "possible typo: 'validaton' should be 'validation'"
120120
type MultipleIssuesWithMissingSpace string
121121

122-
//+requied // want "marker should have space after '//' comment prefix" "possible typo: 'requied' should be 'required'"
122+
// +requied // want "marker should have space after '//' comment prefix" "possible typo: 'requied' should be 'required'"
123123
type MissingSpaceAndTypo string
124124

125-
//+defualt:value:="test" // want "marker should have space after '//' comment prefix" "possible typo: 'defualt' should be 'default'"
125+
// +defualt:value:="test" // want "marker should have space after '//' comment prefix" "possible typo: 'defualt' should be 'default'"
126126
type MissingSpaceDefaultTypoWrongSyntax string
127127

128128
// +kubebuilder:validation:MaxLength:=256
@@ -139,3 +139,6 @@ type ComplexValidStruct struct {
139139
// +kubebuilder:validation:Required
140140
ValidField string `json:"validField"`
141141
}
142+
143+
type NoLintMarker //nolint
144+

pkg/analysis/markertypos/testdata/src/a/a.go.golden

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,4 +112,6 @@ type ComplexValidStruct struct {
112112

113113
// +kubebuilder:validation:Required
114114
ValidField string `json:"validField"`
115-
}
115+
}
116+
117+
type NoLintMarker //nolint

0 commit comments

Comments
 (0)