Fix CRD markers (#4178)

* Fix incorrect Kubebuilder validation markers

This commit corrects several invalid Kubebuilder validation markers that caused controller-gen validation errors.

Changes:

Removed +listType=atomic from non-array fields:

gateway_types.go: Namespaces *RouteNamespaces (line 806)

backendtlspolicy_types.go: WellKnownCACertificates (line 192)

Replaced MaxLength with MaxItems for array fields:

httproute_types.go: AllowedRequestHeaders []string (lines 1674, 1722)

httproute_types.go: AllowedResponseHeaders []string (line 1733)

Removed Minimum/Maximum from non-primitive fields:

xlistenerset_types.go: Port PortNumber (lines 170, 255)

Added CRD marker validation to hack/update-clientset.sh to detect invalid markers during development and CI.

These fixes ensure validation markers are applied only to compatible field types.

Signed-off-by: Killian Golds <kgolds@redhat.com>

* Restore port validation by defining PortNumber types in v1alpha1

  Addresses reviewers feedback by moving validation to the type level.
  Creates StatusPortNumber for status fields requiring valid ports (1-65535).

Signed-off-by: Killian Golds <kgolds@redhat.com>

* Removed invalid printcolumn marker from v1alpha2 ReferenceGrant

The v1alpha2 ReferenceGrant type is marked with +kubebuilder:skipversion,
meaning no CRD is generated for this version (it’s just an alias to v1beta1).
The +kubebuilder:printcolumn marker cannot be applied to a skipped version.

This issue was uncovered by the CRD marker validation added in the previous
commit. The printcolumn is already correctly defined in v1beta1 and does not
need to be duplicated here.

Signed-off-by: Killian Golds <kgolds@redhat.com>

* Rename PortNumber to PortNumberWith0 to prevent misuse

The rename makes it explicit that this type permits 0, helping prevent
accidental use where StatusPortNumber (1–65535) should be preferred.

Signed-off-by: Killian Golds <kgolds@redhat.com>

* Use output:none for CRD marker validation

Simplifies the validation step to avoid generating files or requiring boilerplate headers. The validation still catches invalid markers but does not write any CRDs to disk.

* clean duplicated echo statement

Signed-off-by: Killian Golds <kgolds@redhat.com>

---------

Signed-off-by: Killian Golds <kgolds@redhat.com>

Author: KillianGolds

apis/v1alpha2/referencegrant_types.go

@@ -25,7 +25,6 @@ import (
 // +genclient
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:categories=gateway-api,shortName=refgrant
-// +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
 // +kubebuilder:skipversion
 // +kubebuilder:deprecatedversion:warning="The v1alpha2 version of ReferenceGrant has been deprecated and will be removed in a future release of the API. Please upgrade to v1beta1."
 

apisx/v1alpha1/shared_types.go

@@ -27,7 +27,6 @@ type (
 	Hostname                   = v1.Hostname
 	Kind                       = v1.Kind
 	ObjectName                 = v1.ObjectName
-	PortNumber                 = v1.PortNumber
 	ProtocolType               = v1.ProtocolType
 	RouteGroupKind             = v1.RouteGroupKind
 	SectionName                = v1.SectionName
@@ -38,6 +37,23 @@ type (
 	SessionPersistence         = v1.SessionPersistence
 )
 
+// PortNumberWith0 defines a network port that allows 0 to indicate dynamic
+// port assignment. This type should only be used in spec fields where port 0
+// has the special meaning of "auto-assign a port". In most cases,
+// StatusPortNumber (which excludes 0) should be preferred.
+//
+// +kubebuilder:validation:Minimum=0
+// +kubebuilder:validation:Maximum=65535
+type PortNumberWith0 int32
+
+// StatusPortNumber defines a network port in status fields.
+// Unlike PortNumberWith0, this does not allow 0 since status fields
+// reflect actual assigned ports.
+//
+// +kubebuilder:validation:Minimum=1
+// +kubebuilder:validation:Maximum=65535
+type StatusPortNumber int32
+
 // ParentGatewayReference identifies an API object including its namespace,
 // defaulting to Gateway.
 type ParentGatewayReference struct {

apisx/v1alpha1/xlistenerset_types.go

@@ -167,9 +167,7 @@ type ListenerEntry struct {
 	// +optional
 	//
 	// +kubebuilder:default=0
-	// +kubebuilder:validation:Minimum=0
-	// +kubebuilder:validation:Maximum=65535
-	Port PortNumber `json:"port,omitempty"`
+	Port PortNumberWith0 `json:"port,omitempty"`
 
 	// Protocol specifies the network protocol this listener expects to receive.
 	// +required
@@ -253,11 +251,8 @@ type ListenerEntryStatus struct {
 
 	// Port is the network port the listener is configured to listen on.
 	//
-	// +kubebuilder:validation:Minimum=1
-	// +kubebuilder:validation:Maximum=65535
-	//
 	// +required
-	Port PortNumber `json:"port"`
+	Port StatusPortNumber `json:"port"`
 
 	// SupportedKinds is the list indicating the Kinds supported by this
 	// listener. This MUST represent the kinds an implementation supports for

applyconfiguration/apisx/v1alpha1/listenerentry.go

@@ -118,3 +118,10 @@ go run sigs.k8s.io/controller-tools/cmd/controller-gen \
   object:headerFile=${SCRIPT_ROOT}/hack/boilerplate/boilerplate.generatego.txt \
   paths="./apis/..." \
   paths="./apisx/..."
+
+echo "Validating CRD markers"
+go run sigs.k8s.io/controller-tools/cmd/controller-gen \
+  crd \
+  paths="./apis/..." \
+  paths="./apisx/..." \
+  output:none