chore(source): code cleanup

Author: ivankatliarchuk

.github/workflows/ci.yaml

@@ -17,7 +17,11 @@ jobs:
       checks: write  #  to create a new check based on the results (shogo82148/actions-goveralls)
 
     name: Build
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        # tests for target OS
+        os: [ubuntu-latest, macos-latest]
     steps:
 
     - name: Check out code into the Go module directory
@@ -27,6 +31,7 @@ jobs:
       uses: actions/setup-go@v5
       with:
         go-version-file: go.mod
+        check-latest: true
       id: go
 
     - name: Install CI
@@ -37,7 +42,7 @@ jobs:
       run: |
             apt update
             apt install -y make gcc libc-dev git
-      if: github.actor == 'nektos/act'
+      if: github.actor == 'nektos/act' && matrix.os == 'ubuntu-latest'
 
     - name: Test
       run: make test
@@ -46,5 +51,5 @@ jobs:
       uses: shogo82148/actions-goveralls@v1
       with:
         path-to-profile: profile.cov
-      if: github.actor != 'nektos/act'
+      if: github.actor != 'nektos/act' && matrix.os == 'ubuntu-latest'
       continue-on-error: true

.github/workflows/dependency-update.yaml

@@ -17,7 +17,7 @@ jobs:
         uses: actions/checkout@v4.2.2
       # https://github.com/renovatebot/github-action
       - name: self-hosted renovate
-        uses: renovatebot/github-action@v41.0.18
+        uses: renovatebot/github-action@v41.0.22
         with:
           # https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication
           token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/docs.yaml

@@ -19,7 +19,7 @@ jobs:
         with:
           fetch-depth: 0
 
-      - uses: actions/setup-python@8d9ed9ac5c53483de85588cdf95a591a75ab9f55 # v5.5.0
+      - uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
           python-version: "3.12"
           cache: "pip"

.github/workflows/json-yaml-validate.yml

@@ -17,7 +17,7 @@ jobs:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
 
       - name: json-yaml-validate
-        uses: GrantBirki/json-yaml-validate@v3.2.1
+        uses: GrantBirki/json-yaml-validate@v3.3.0
         with:
           comment: "true" # enable comment mode
           yaml_exclude_regex: "(charts/external-dns/templates.*|mkdocs.yml)"

.github/workflows/lint-test-chart.yaml

@@ -78,7 +78,7 @@ jobs:
         run: ah lint --kind helm || exit 1
 
       - name: Install Python
-        uses: actions/setup-python@8d9ed9ac5c53483de85588cdf95a591a75ab9f55 # v5.5.0
+        uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
         with:
           token: ${{ github.token }}
           python-version: "3.x"

.github/workflows/lint.yaml

@@ -26,7 +26,7 @@ jobs:
         files: '.'
         config_file: ".markdownlint.json"
 
-    - name: Set up Go 1.x
+    - name: Set up Go
       uses: actions/setup-go@v5
       with:
         go-version-file: go.mod
@@ -44,11 +44,11 @@ jobs:
 
     # https://github.com/golangci/golangci-lint-action?tab=readme-ov-file#verify
     - name: Verify linter configuration and Lint go code
-      uses: golangci/golangci-lint-action@v7
+      uses: golangci/golangci-lint-action@v8
       with:
         verify: true
         args: --timeout=30m
-        version: v2.0
+        version: v2.1
 
       # Run Spectral
     - name: Lint OpenAPI spec

.golangci.yml

@@ -1,7 +1,8 @@
+# https://golangci-lint.run/usage/configuration/
 version: "2"
 linters:
   default: none
-  enable:
+  enable: # golangci-lint help linters
     - dogsled
     - goprintffuncname
     - govet
@@ -13,6 +14,9 @@ linters:
     - unconvert
     - unused
     - whitespace
+    - predeclared # Find code that shadows one of Go's predeclared identifiers
+    - sloglint # Ensure consistent code style when using log/slog
+    - asciicheck  # Checks that all code identifiers does not have non-ASCII symbols in the name
   settings:
     exhaustive:
       default-signifies-exhaustive: false

CONTRIBUTING.md

@@ -12,6 +12,8 @@ We have full documentation on how to get started contributing here:
 - [Kubernetes Contributor Guide](https://git.k8s.io/community/contributors/guide) - Main contributor documentation, or you can just jump directly to the [contributing section](https://git.k8s.io/community/contributors/guide#contributing)
 - [Contributor Cheat Sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet) - Common resources for existing developers
 
+This project follows the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification on PR title. The explicit commit history is used, among other things, to provide a readable changelog in release notes.
+
 ## Mentorship
 
 - [Mentoring Initiatives](https://git.k8s.io/community/mentoring) - We have a diverse set of mentorship programs available that are always looking for volunteers!

Makefile

@@ -32,10 +32,6 @@ else
 CONTROLLER_GEN=$(shell which controller-gen)
 endif
 
-#? controller-gen-install: download controller-gen if necessary
-controller-gen-install:
-	@scripts/install-tools.sh --generator
-
 #? golangci-lint-install: Install golangci-lint tool
 golangci-lint-install:
 	@scripts/install-tools.sh --golangci
@@ -67,10 +63,11 @@ oas-lint:
 .PHONY: lint
 lint: licensecheck go-lint oas-lint
 
-#? crd: Generates CRD using controller-gen
+#? crd: Generates CRD using controller-gen and copy it into chart
 .PHONY: crd
 crd: controller-gen-install
-	${CONTROLLER_GEN} crd:crdVersions=v1 paths="./endpoint/..." output:crd:stdout > docs/contributing/crd-source/crd-manifest.yaml
+	${CONTROLLER_GEN} crd:crdVersions=v1 paths="./endpoint/..." output:crd:stdout > config/crd/standard/dnsendpoint.yaml
+	cp -f config/crd/standard/dnsendpoint.yaml charts/external-dns/crds/dnsendpoint.yaml
 
 #? test: The verify target runs tasks similar to the CI tasks, but without code coverage
 .PHONY: test
@@ -201,3 +198,7 @@ helm-template:
 helm-lint:
 	scripts/helm-tools.sh --schema
 	scripts/helm-tools.sh --docs
+
+.PHONY: go-dependency
+go-dependency: ## Dependency maintanance
+	go mod tidy

charts/external-dns/CHANGELOG.md

@@ -18,6 +18,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [UNRELEASED]
 
+### Changed
+
+- Allow extraArgs to also be a map enabling overrides of individual values ([#5293](https://github.com/kubernetes-sigs/external-dns/pull/5293)) _@frittentheke
+
+### Fixed
+
+- Fixed wrong type definitions for webhook probes. ([#5297](https://github.com/kubernetes-sigs/external-dns/pull/5297)) _@semnell_
+
 ## [v1.16.1] - 2025-04-10
 
 ### Changed