update golangci-lint to v2.5.0 (#3323)

update golangci-lint to v2.5.0



Update examples/tokenreview/tokenreview.go

Update pkg/reconcile/reconcile.go

Co-authored-by: Christian Schlotter <christi.schlotter@gmail.com>

Author: dongjiang1989

.github/workflows/golangci-lint.yml

@@ -34,6 +34,6 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # tag=v8.0.0
         with:
-          version: v2.4.0
+          version: v2.5.0
           args: --output.text.print-linter-name=true --output.text.colors=true --timeout 10m
           working-directory: ${{matrix.working-directory}}

.golangci.yml

@@ -22,10 +22,12 @@ linters:
     - goconst
     - gocritic
     - gocyclo
+    - godoclint
     - goprintffuncname
     - govet
     - importas
     - ineffassign
+    - iotamixing
     - makezero
     - misspell
     - nakedret

examples/crd/pkg/groupversion_info.go

@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+// Package pkg contains API Schema definitions for the chaosapps v1 API group
 // +kubebuilder:object:generate=true
 // +groupName=chaosapps.metamagical.io
 package pkg

examples/tokenreview/tokenreview.go

@@ -28,7 +28,7 @@ import (
 type authenticator struct {
 }
 
-// authenticator admits a request by the token.
+// Handle admits a request by the token.
 func (a *authenticator) Handle(ctx context.Context, req authentication.Request) authentication.Response {
 	if req.Spec.Token == "invalid" {
 		return authentication.Unauthenticated("invalid is an invalid token", v1.UserInfo{})

pkg/log/zap/flags.go

@@ -14,8 +14,6 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-// Package zap contains helpers for setting up a new logr.Logger instance
-// using the Zap logging framework.
 package zap
 
 import (

pkg/reconcile/reconcile.go

@@ -174,7 +174,7 @@ type terminalError struct {
 	err error
 }
 
-// This function will return nil if te.err is nil.
+// Unwrap returns nil if te.err is nil.
 func (te *terminalError) Unwrap() error {
 	return te.err
 }