Skip to content

Commit c0dd95a

Browse files
committed
taint propagation: in-place propagate via MachineDeployment and MachineSet
1 parent eebd73b commit c0dd95a

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

internal/controllers/machinedeployment/machinedeployment_rollout_planner.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ func computeDesiredMS(ctx context.Context, deployment *clusterv1.MachineDeployme
315315
desiredMS.Spec.Template.Spec.Deletion.NodeDrainTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeDrainTimeoutSeconds
316316
desiredMS.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
317317
desiredMS.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
318+
desiredMS.Spec.Template.Spec.Taints = deployment.Spec.Template.Spec.Taints
318319

319320
return desiredMS, nil
320321
}

internal/controllers/machineset/machineset_controller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,6 +525,7 @@ func (r *Reconciler) syncMachines(ctx context.Context, s *scope) (ctrl.Result, e
525525
m.Spec.Deletion.NodeDeletionTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
526526
m.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
527527
m.Spec.MinReadySeconds = machineSet.Spec.Template.Spec.MinReadySeconds
528+
m.Spec.Taints = machineSet.Spec.Template.Spec.Taints
528529

529530
// Set machine's up to date condition
530531
if upToDateCondition != nil {
@@ -903,6 +904,7 @@ func (r *Reconciler) computeDesiredMachine(machineSet *clusterv1.MachineSet, exi
903904
desiredMachine.Spec.Deletion.NodeDeletionTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
904905
desiredMachine.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
905906
desiredMachine.Spec.MinReadySeconds = machineSet.Spec.Template.Spec.MinReadySeconds
907+
desiredMachine.Spec.Taints = machineSet.Spec.Template.Spec.Taints
906908

907909
return desiredMachine, nil
908910
}

0 commit comments

Comments
 (0)