Skip to content

Commit 8b7da19

Browse files
Address feedback
1 parent a956f3e commit 8b7da19

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

internal/controllers/machinedeployment/machinedeployment_rollout_rollingupdate_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1029,7 +1029,7 @@ func TestReconcileInPlaceUpdateIntent(t *testing.T) {
10291029
},
10301030
{
10311031
name: "When moving replicas from oldMS to newMS, drop usage of MaxSurge in the newMS scale up intent when there newMS is scaling from a previous reconcile (maxSurge 3, maxUnavailable 1)",
1032-
md: createMD("v6", 6, withRollingUpdateStrategy(3, 1)),
1032+
md: createMD("v2", 6, withRollingUpdateStrategy(3, 1)),
10331033
newMS: createMS("ms2", "v2", 3, withStatusReplicas(2), withStatusUpToDateReplicas(2), withStatusAvailableReplicas(2)), // scaling from a previous reconcile
10341034
oldMS: []*clusterv1.MachineSet{
10351035
createMS("ms1", "v1", 3),
@@ -1068,8 +1068,8 @@ func TestReconcileInPlaceUpdateIntent(t *testing.T) {
10681068
},
10691069
machines: []*clusterv1.Machine{
10701070
createM("m1", "ms1", "v1"),
1071-
createM("m2", "ms2", "v1"),
1072-
createM("m3", "ms2", "v1"),
1071+
createM("m2", "ms2", "v2"),
1072+
createM("m3", "ms2", "v2"),
10731073
},
10741074
scaleIntents: map[string]int32{
10751075
"ms2": 3, // +1 => MD expect 3, has currently 3 replicas, +1 replica it is using maxSurge
@@ -1126,8 +1126,8 @@ func TestReconcileInPlaceUpdateIntent(t *testing.T) {
11261126
},
11271127
machines: []*clusterv1.Machine{
11281128
createM("m1", "ms1", "v1"),
1129-
createM("m2", "ms2", "v1"),
1130-
createM("m3", "ms2", "v1"),
1129+
createM("m2", "ms2", "v2"),
1130+
createM("m3", "ms2", "v2"),
11311131
},
11321132
scaleIntents: map[string]int32{
11331133
"ms2": 3, // +1 => MD expect 3, has currently 3 replicas, +1 replica it is using maxSurge

0 commit comments

Comments
 (0)