Skip to content

Commit 82b356f

Browse files
committed
taint propagation: in-place propagate via MachineDeployment and MachineSet
1 parent 5053c12 commit 82b356f

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

internal/controllers/machinedeployment/machinedeployment_rollout_planner.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -315,6 +315,7 @@ func computeDesiredMS(ctx context.Context, deployment *clusterv1.MachineDeployme
315315
desiredMS.Spec.Template.Spec.Deletion.NodeDrainTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeDrainTimeoutSeconds
316316
desiredMS.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
317317
desiredMS.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = deployment.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
318+
desiredMS.Spec.Template.Spec.Taints = deployment.Spec.Template.Spec.Taints
318319

319320
return desiredMS, nil
320321
}

internal/controllers/machineset/machineset_controller.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -678,6 +678,7 @@ func (r *Reconciler) syncMachines(ctx context.Context, s *scope) (ctrl.Result, e
678678
m.Spec.Deletion.NodeDeletionTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
679679
m.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
680680
m.Spec.MinReadySeconds = machineSet.Spec.Template.Spec.MinReadySeconds
681+
m.Spec.Taints = machineSet.Spec.Template.Spec.Taints
681682

682683
// Set machine's up to date condition
683684
if upToDateCondition != nil {
@@ -1236,6 +1237,7 @@ func (r *Reconciler) computeDesiredMachine(machineSet *clusterv1.MachineSet, exi
12361237
desiredMachine.Spec.Deletion.NodeDeletionTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeDeletionTimeoutSeconds
12371238
desiredMachine.Spec.Deletion.NodeVolumeDetachTimeoutSeconds = machineSet.Spec.Template.Spec.Deletion.NodeVolumeDetachTimeoutSeconds
12381239
desiredMachine.Spec.MinReadySeconds = machineSet.Spec.Template.Spec.MinReadySeconds
1240+
desiredMachine.Spec.Taints = machineSet.Spec.Template.Spec.Taints
12391241

12401242
return desiredMachine, nil
12411243
}

0 commit comments

Comments
 (0)