Skip to content

Bump github.com/golangci/golangci-lint/v2 from 2.5.0 to 2.6.0 #2521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump github.com/golangci/golangci-lint/v2 from 2.5.0 to 2.6.0 #2521

wants to merge 1 commit into from
+212 −155

Conversation

@ChandrikaHarish
Copy link

@ChandrikaHarish ChandrikaHarish commented Nov 5, 2025 •
edited
Loading

What this PR does / why we need it:
Resolved lint issues arising due to lint ci version bump.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Bump github.com/golangci/golangci-lint/v2 from 2.5.0 to 2.6.0

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Nov 5, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ChandrikaHarish / name: chandrikaBhc (8c1d5d7)

@netlify
Copy link

netlify bot commented Nov 5, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 8c1d5d7
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/6914550bfc86dc000893b8bf
😎 Deploy Preview https://deploy-preview-2521.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChandrikaHarish
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

Welcome @ChandrikaHarish!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 5, 2025

Hi @ChandrikaHarish. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2025
@ChandrikaHarish ChandrikaHarish mentioned this pull request Nov 5, 2025
Closed
@ChandrikaHarish ChandrikaHarish changed the title Bump github.com/golangci/golangci-lint/v2 from 2.5.0 to 2.6.0 in /hac… Bump github.com/golangci/golangci-lint/v2 from 2.5.0 to 2.6.0 Nov 5, 2025
@Prajyot-Parab
Copy link
Contributor

Prajyot-Parab commented Nov 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 5, 2025
@ChandrikaHarish
Copy link
Author

ChandrikaHarish commented Nov 6, 2025

/check-cla

@ChandrikaHarish
Copy link
Author

ChandrikaHarish commented Nov 6, 2025

/easycla

1 similar comment
@Karthik-K-N
Copy link
Contributor

Karthik-K-N commented Nov 6, 2025

/easycla

@Prajyot-Parab
Copy link
Contributor

Prajyot-Parab commented Nov 6, 2025

/check-cla
/easycla

@ChandrikaHarish ChandrikaHarish force-pushed the bump-lint-version branch 4 times, most recently from 4519395 to e903eb0 Compare November 7, 2025 06:41
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 7, 2025
Karthik-K-N
Karthik-K-N reviewed Nov 10, 2025
View reviewed changes
api/v1beta1/types.go
Comment on lines 95 to 98

// Deprecated: This field has no function and is going to be removed in the next release.

// +optional
Copy link
Contributor

@Karthik-K-N Karthik-K-N Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow something like this https://github.com/openshift-cloud-team/cluster-api/blob/ee2b6e857aa21f0a94c80024f60bf558a4a151a7/api/core/v1beta1/cluster_types.go#L564-L570

// Deprecated: This field has no function and is going to be removed in the next release.
//
// +optional

It will preserve the Deprecated fields in the CRD.
Here and everywhere.

Karthik-K-N
Karthik-K-N reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
Amulyam24
Amulyam24 reviewed Nov 12, 2025
View reviewed changes
pkg/endpoints/endpoints.go Outdated

// FetchRCEndpoint will return resource controller endpoint.
// Deprecated: User FetchEndpoints instead.

Copy link
Contributor

@Amulyam24 Amulyam24 Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Author

@ChandrikaHarish ChandrikaHarish Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved by adding revive exclude-rules for SA1019 in golangci.yml

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 12, 2025

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prajyot-Parab Prajyot-Parab Awaiting requested review from Prajyot-Parab

2 more reviewers

@Amulyam24 Amulyam24 Amulyam24 left review comments

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Karthik-K-N Karthik-K-N

Labels

area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ChandrikaHarish @k8s-ci-robot @Prajyot-Parab @Karthik-K-N @Amulyam24